Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop register to prom registry #84135

Merged
merged 1 commit into from Nov 11, 2019
Merged

Stop register to prom registry #84135

merged 1 commit into from Nov 11, 2019

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Stop register to Prometheus registry after migration.

Which issue(s) this PR fixes:
Fixes #83876

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 21, 2019
@RainbowMango RainbowMango mentioned this pull request Oct 21, 2019
Closed
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 21, 2019
@s-urbaniak
Copy link
Contributor

/approve

@RainbowMango
Copy link
Member Author

Thanks @s-urbaniak .

/hold
for @logicalhan confirm or all migration done.

/assign @logicalhan
/priority important-soon
/remove-sig api-machinery
/remove-sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 21, 2019
This was referenced Oct 30, 2019
Merged
Merged
Merged
Merged
Merged
@RainbowMango
Copy link
Member Author

@logicalhan @brancz
Can we move forward this now? Or what else should be done first?

logicalhan
logicalhan approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, RainbowMango, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2019
@logicalhan
Copy link
Member

/hold

@RainbowMango
Copy link
Member Author

/hold cancel
as the last prometheus.DefaultRegistry(#84987) has been migrated to component base.

/milestone v1.17

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4cdb15f into kubernetes:master Nov 11, 2019
@RainbowMango
Copy link
Member Author

@logicalhan @brancz
After this PR, I rebased and re-trigger the #83836, #83837, #83838, #83839, #83841.

But #83837 and #83838 failed for the same reason. It's weird!
I failed to dig out the root cause of the CI failing today, I will continue tomorrow.

I'm afraid I have done something wrong or missed something.
If you have something coming up, please let me know.

@RainbowMango RainbowMango deleted the pr_remove_backoff branch November 26, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@logicalhan logicalhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Panic happends when deprecating metrics
4 participants
@RainbowMango @s-urbaniak @k8s-ci-robot @logicalhan