Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate kubelet custom metrics to stability framework part 2 #84987

Conversation

@RainbowMango
Copy link
Member

RainbowMango commented Nov 8, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently, custom metrics emitted from kubelet do not offer any stability guarantees.

And #83062 tries to make it possible to do so.

About metrics stability please refer to KEP .

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
IMO, we can use the stability framework to offer stability guarantee and drop the traditional versioned endpoint like xxx/v1alpha.

More details please refer to why not traditional versioned endpoint.

Please let me know if we need a follow-up issue or KEP.

Does this PR introduce a user-facing change?:

Following metrics from kubelet are now marked as with the ALPHA stability level:
node_cpu_usage_seconds_total
node_memory_working_set_bytes
container_cpu_usage_seconds_total
container_memory_working_set_bytes
scrape_error

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md
- [Usage]: <link>
- [Other doc]: <link>

/priority important-soon
/milestone v1.17

RainbowMango added 3 commits Nov 8, 2019
Update bazel by hack/update-bazel.sh
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 8, 2019

@k8s-ci-robot k8s-ci-robot requested review from brancz, dashpole and logicalhan Nov 8, 2019
@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Nov 8, 2019

/lgtm
/approve

I agree that we should migrate away from the versioned endpoint after this PR. I think adding this prometheus handler at /metrics/resource in addition to /metrics/resource/v1alpha1 should be non-controversial. I'm not sure how long we should keep the /metrics/resource/v1alpha1 around, but 3 releases seems reasonable so.

Copy link
Contributor

logicalhan left a comment

/lgtm
/approve

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 10, 2019

@josiahbjorgaard

This comment has been minimized.

Copy link
Contributor

josiahbjorgaard commented Nov 11, 2019

A quick note that this PR will need to be merged before code freeze on 11/14 at 5PM pacific time for v1.17.

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Nov 11, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, derekwaynecarr, logicalhan, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ec86baf into kubernetes:master Nov 11, 2019
15 checks passed
15 checks passed
cla/linuxfoundation RainbowMango authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@RainbowMango RainbowMango deleted the RainbowMango:pr_migrate_custom_collector_kubelet_part2 branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.