Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring EndpointSlices are not used for Windows kube-proxy implementations #86016

Merged
merged 1 commit into from Dec 17, 2019
Merged

Ensuring EndpointSlices are not used for Windows kube-proxy implementations #86016

merged 1 commit into from Dec 17, 2019

Conversation

robscott
Copy link
Member

@robscott robscott commented Dec 6, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
This ensures that EndpointSlices will not be used by Windows implementations of kube-proxy since they do not currently support EndpointSlices.

Which issue(s) this PR fixes:
Fixes #85352

Does this PR introduce a user-facing change?:

Fixes kube-proxy when EndpointSlice feature gate is enabled on Windows.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network
/priority important-soon
/cc @freehan @JocelynBerrendonner

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: JocelynBerrendonner.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
This ensures that EndpointSlices will not be used by Windows implementations of kube-proxy since they do not currently support EndpointSlices.

Which issue(s) this PR fixes:
Fixes #85352

Does this PR introduce a user-facing change?:

Fixes kube-proxy when EndpointSlice feature gate is enabled on Windows.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network
/priority important-soon
/cc @freehan @JocelynBerrendonner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2019
@robscott
Copy link
Member Author

robscott commented Dec 7, 2019

/test pull-kubernetes-e2e-windows-gce

JocelynBerrendonner
JocelynBerrendonner approved these changes Dec 7, 2019
View reviewed changes
Copy link

@JocelynBerrendonner JocelynBerrendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for making this change!

@robscott
Copy link
Member Author

robscott commented Dec 7, 2019

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2019
@robscott
Copy link
Member Author

robscott commented Dec 9, 2019

/test pull-kubernetes-e2e-windows-gce

Going to hold this until I revert the change to enable EndpointSlices by default.
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Dec 9, 2019
@robscott
Copy link
Member Author

robscott commented Dec 9, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2019
@robscott
Copy link
Member Author

robscott commented Dec 9, 2019

/retest

@robscott
Copy link
Member Author

robscott commented Dec 9, 2019

@freehan I think this should be good to go now. I temporarily enabled EndpointSlices by default on this PR for the sake of running Windows tests against it, and they seemed to pass as much as they usually do (not fully but mostly). The failures that existed did not seem related to networking in any way, and the kube-proxy logs looked reasonable to me. https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/86016/pull-kubernetes-e2e-windows-gce/1204123396347006976/artifacts/e2e-b2702382aa-95646-windows-node-group-0cnw/kube-proxy.log

@robscott robscott mentioned this pull request Dec 10, 2019
Merged
@robscott
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2019
@freehan
Copy link
Contributor

freehan commented Dec 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 078344c into kubernetes:master Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

@robscott: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-windows-gce dfa04bf link /test pull-kubernetes-e2e-windows-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@robscott robscott mentioned this pull request Mar 13, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 4, 2020
@k8s-ci-robot
Merge pull request #89117 from robscott/automated-cherry-pick-of-#86092-
983a0a7 
#86016-upstream-release-1.17

Automated cherry pick of #86092: Ensuring kube-proxy does not mutate shared EndpointSlices #86016: Ensuring EndpointSlices are not used for Windows kube-proxy
@robscott robscott deleted the endpointslice-windows-proxy branch March 11, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JocelynBerrendonner JocelynBerrendonner JocelynBerrendonner approved these changes

@freehan freehan Awaiting requested review from freehan

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Kube-proxy with EndpointSlice feature on doesn't work on Windows.
5 participants
@robscott @k8s-ci-robot @freehan @fejta-bot @JocelynBerrendonner