-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce library of helper plugins that can be used by in-tree and out of tree components #86236
Comments
@alculquicondor @ahg-g Added for reference around our discussion |
/sig scheduling |
/cc |
Thanks @hprateek43 for opening this. We will probably need to progress a bit more with #85822 before being able to suggest a solution to this. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/close |
@alculquicondor: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
In general, we might need a library of helper functions that both in-tree and out-of-tree plugins can use. We should finalise a location for this library and refactor common code components there.
Why is this needed:
Currently the homegrown
.import-restrictions
tool requires explicit listing for all transitive dependencies, even internal ones. However, the golang compiler does not allow the import of internal libraries anyway. This leads to a challenge is cleanups of components likescheduler
ascontroller
has transitive dependencies around theerrchannels
. This could have been circumvented if such code was placed in a common library that can be used by multiple components.Reference PRs that were affected by this:
#85773
#84336
The text was updated successfully, but these errors were encountered: