Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce library of helper plugins that can be used by in-tree and out of tree components #86236

Closed
hprateek43 opened this issue Dec 13, 2019 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@hprateek43
Copy link
Contributor

What would you like to be added:
In general, we might need a library of helper functions that both in-tree and out-of-tree plugins can use. We should finalise a location for this library and refactor common code components there.

Why is this needed:
Currently the homegrown .import-restrictions tool requires explicit listing for all transitive dependencies, even internal ones. However, the golang compiler does not allow the import of internal libraries anyway. This leads to a challenge is cleanups of components like scheduler as controller has transitive dependencies around the errchannels. This could have been circumvented if such code was placed in a common library that can be used by multiple components.

Reference PRs that were affected by this:
#85773
#84336

@hprateek43 hprateek43 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 13, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 13, 2019
@hprateek43
Copy link
Contributor Author

@alculquicondor @ahg-g Added for reference around our discussion

@hprateek43
Copy link
Contributor Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 13, 2019
@tanjunchen
Copy link
Member

/cc

@alculquicondor
Copy link
Member

Thanks @hprateek43 for opening this. We will probably need to progress a bit more with #85822 before being able to suggest a solution to this.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 11, 2020
@alculquicondor
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

5 participants