Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If lastTimestamp is not set use firstTimestamp when printing event #86557

Merged
merged 1 commit into from Feb 15, 2020
Merged

If lastTimestamp is not set use firstTimestamp when printing event #86557

merged 1 commit into from Feb 15, 2020

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Dec 23, 2019

What type of PR is this?
/kind bug

Special notes for your reviewer:
/assign @smarterclayton

Does this PR introduce a user-facing change?:

If lastTimestamp is not set use firstTimestamp when printing event

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Feb 14, 2020

/priority backlog
/sig cli
/assign @sallyom

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 14, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Feb 14, 2020

/retest

@sallyom
Copy link
Contributor

sallyom commented Feb 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2e0cf7e into kubernetes:master Feb 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 15, 2020
@soltysh soltysh deleted the fix_events branch February 21, 2020 21:36
This was referenced Mar 10, 2020
Merged
Closed
@soltysh soltysh mentioned this pull request Apr 9, 2020
Merged
@soltysh soltysh mentioned this pull request May 13, 2020
Merged
@soltysh soltysh mentioned this pull request May 13, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 18, 2020
@k8s-ci-robot
Merge pull request #91055 from soltysh/automated-cherry-pick-of-#86557-…
6c458a5 
…#89999-upstream-release-1.17

Automated cherry pick of #86557: If lastTimestamp is not set use firstTimestamp when printing #89999: If firstTimestamp is not set use eventTime when printing
k8s-ci-robot added a commit that referenced this pull request Jun 18, 2020
@k8s-ci-robot
Merge pull request #91056 from soltysh/automated-cherry-pick-of-#86557-…
1792a85 
…#89999-upstream-release-1.16

Automated cherry pick of #86557: If lastTimestamp is not set use firstTimestamp when printing #89999: If firstTimestamp is not set use eventTime when printing
This was referenced Aug 26, 2020
Closed
Merged
@zzzkl zzzkl mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@smarterclayton smarterclayton

@sallyom sallyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@soltysh @k8s-ci-robot @sallyom @fejta-bot @smarterclayton