Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Refactor agnhost image pod usage #87266

Merged
merged 1 commit into from Sep 23, 2020
Merged

tests: Refactor agnhost image pod usage #87266

merged 1 commit into from Sep 23, 2020

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jan 16, 2020 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Creates a few agnhost related functions that creates agnhost pods / containers for general purposes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 16, 2020
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 16, 2020
@jennybuckley
Copy link

/assign @yliaog

@claudiubelu claudiubelu force-pushed the tests/agnhost-usage-refactor branch 4 times, most recently from 385ac73 to 369e557 Compare January 21, 2020 23:31
@claudiubelu
Copy link
Contributor Author

/retest

@claudiubelu claudiubelu changed the title WIP: tests: Refactor agnhost image pod usage tests: Refactor agnhost image pod usage Jan 23, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@claudiubelu
Copy link
Contributor Author

/retest

This was referenced Sep 2, 2020
Merged
Merged
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 2, 2020
@claudiubelu
Copy link
Contributor Author

@claudiubelu again, thank you for working on this.
After taking a better look at this, the refactor of the pod utility functions in the e2e framework definetely seems useful and the API for how to use it seems to be useful in a lot of places.
+1 for the idea.

In terms of getting this into kubernetes: I think it would be better to break this into multiple PRs. Start with the one refactoring the pod utility functions in test/e2e/framework/pod along with any necessary work to run agnhost. Then one PR for each test package (i.e., 1 PR for test/e2e/apimachinery, 1 for test/e2e/common, 1 for test/e2e/node).
Breaking it up will make it easier to review (gave this PR a read from end-to-end but very possible i missed some details) and easier to track changes in case anything breaks (which is always possible).

Another thing, I apologize it has taken so long to review this and will make sure to work more with you going forward to prevent this kind of delay from happening again.

Sure. I've split this PR into 4 parts. The changes to some of the packages are actually pretty small, so I've put a few of them in the same PR, and it's still not big. The test/e2e/common/ changes were bigger, so I've split those into 2 PRs.

@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@oomichi
Copy link
Member

oomichi commented Sep 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@claudiubelu
Copy link
Contributor Author

/assign @smarterclayton

@claudiubelu claudiubelu mentioned this pull request Sep 7, 2020
Merged
@yliaog
Copy link
Contributor

yliaog commented Sep 7, 2020

/lgtm

alejandrox1
alejandrox1 reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v1.20

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, claudiubelu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@alejandrox1 alejandrox1 moved this from PR - Needs attention from author to PR - Reviewer approved in Testing Commons Sep 22, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 22, 2020 •
edited

@claudiubelu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce c4e745e11797a542fc0188759582e41440d119d5 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-device-plugin-gpu c4e745e11797a542fc0188759582e41440d119d5 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-kubemark-e2e-gce-big c4e745e11797a542fc0188759582e41440d119d5 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 3783e03 into kubernetes:master Sep 23, 2020
Testing Commons automation moved this from PR - Reviewer approved to Done Sep 23, 2020
adelina-t added a commit to adelina-t/kubernetes that referenced this pull request Oct 1, 2020
@adelina-t
Fix test "[sig-windows] DNS should support configurable pod DNS servers"
9d0e1c6 
With the changes introduced by agnhost refactoring PR ( kubernetes#87266 ), this test was left searching for a invalid container name. Updated to the proper name.
@aojea aojea mentioned this pull request Oct 1, 2020
Merged
hidetatz pushed a commit to hidetatz/kubernetes that referenced this pull request Jan 12, 2021
@adelina-t
Fix test "[sig-windows] DNS should support configurable pod DNS servers"
45df0f3 
With the changes introduced by agnhost refactoring PR ( kubernetes#87266 ), this test was left searching for a invalid container name. Updated to the proper name.
This was referenced Feb 16, 2021
Closed
Merged
chewong pushed a commit to chewong/kubernetes that referenced this pull request Feb 25, 2021
@adelina-t
Fix test "[sig-windows] DNS should support configurable pod DNS servers"
9a8f4c6 
With the changes introduced by agnhost refactoring PR ( kubernetes#87266 ), this test was left searching for a invalid container name. Updated to the proper name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKielty RobertKielty RobertKielty left review comments

@alejandrox1 alejandrox1 alejandrox1 left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@smarterclayton smarterclayton

@oomichi oomichi

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Testing Commons
  
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet