Automated cherry pick of #87266: #93196: #94438: #94653: #95867: #96294: #96330: #96479: #96626: #96644: #96690: #96843: #99133
Conversation
Creates a few agnhost related functions that creates agnhost pods / containers for general purposes. The following commits will refactor tests to use those functions.
Make pre provisioned snapshots using CSI driver by 1. Take a dynamic snapshot with retain policy 2. Delete the dynamic snapshot and content 3. Create a preprovisioned snapshot with snapshotHandle This commit adds a preprovisiond test pattern, all snapshots made using create snapshot resource become prepv snapshots. All exisitng test cases now run again with prepv snapshots.
Prepv snapshots only need to specify driver.
…ime taken on prow.
…snapcontent name instead
A previous commit created a few agnhost related functions that creates agnhost pods / containers for general purposes. Refactors tests to use those functions.
e2e tests should log stdout / stderr of failed commands executed via PodExec. "command terminated with exit code 1" is not really useful.
Add a separate in-tree gcepd driver for windows cluster because it does not support certain features as Linux driver. Change-Id: I2fca86b3f32f17db7703c46a36944d9ee51f355f
Update snapshottable and disable disruptive test for Windows Change-Id: I9d6beb25078c1941e405bf61545caae30326ddd1
Update storage test suits to enable some tests on Windows Change-Id: I1f596bb9f7a0f41ae398aec43406ee5c753cdce3
Update storage topology tests setup for Windows Change-Id: I9a2773b91806a10553db06f61f7259db4df71c3b
Some storage tests has commands not available in Windows. Mark them as LinuxOnly now. Will check later to see whether equivalent windows commands are available. Change-Id: I41b5668c855b2754a2e332cff4e90ebf2981aca0
This test is not working for windows yet due to commands issued in pod are not available for windows Change-Id: Ia0b03afd6dfe0bbb1ab00dc821775450a7e8ce54
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
do-not-merge/hold
|
@jingxu97: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, jingxu97, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dims
added
cncf-cla: yes
hasheddan
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
|
/lgtm |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
|
||
| // NewExecPodSpec returns the pod spec of hostexec pod | ||
| func NewExecPodSpec(ns, name string, hostNetwork bool) *v1.Pod { | ||
| pod := NewAgnhostPod(ns, name, nil, nil, nil) |
There was a problem hiding this comment.
this is the bug fixed by https://github.com/kubernetes/kubernetes/pull/95229/files
|
I am not sure how to correctly add a commit to this cherrypick, so just use cherrypick script to generate anther PR #99220 Please review the new one. Thanks! |
should we close this one then? |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
/close |
|
@dims: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry pick of #87266 #93196 #94438 #94653 #95867 #96294 #96330 #96479 #96626 #96644 #96690 #96843 on release-1.19.
#87266: tests: Refactor agnhost image pod usage
#93196: Minor cleanup in snapshot test suite.
#94438: tests: Refactors agnhost image pod usage in tests
#94653: Tolerate NotFound errors when deleting snapshots
#95867: Log PodExec stdout + stderr
#96294: Separate in-tree gcepd driver for windows
#96330: Modify storage snapshottable and disruptive test for Windows
#96479: Update storage test suits for Windows
#96626: Update topology tests for windows
#96644: Mark some storage tests as LinuxOnly
#96690: Add linuxonly on one multivolume test
#96843: Remove unnecessary snapshot ability check
For details on the cherry pick process, see the cherry pick requests page.