Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck w/e in cluster/gce/gci/configure-helper.sh #90433

Merged
merged 16 commits into from
Aug 28, 2020
Merged

Fix shellcheck w/e in cluster/gce/gci/configure-helper.sh #90433

merged 16 commits into from
Aug 28, 2020

Conversation

joakimr-axis
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fixes shellcheck failures in cluster/gce/gci/configure-helper.sh

Which issue(s) this PR fixes:
ref: #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @joakimr-axis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 24, 2020
@joakimr-axis
Copy link
Contributor Author

/assign @cheftako @mikedanese

@joakimr-axis joakimr-axis mentioned this pull request Apr 24, 2020
Closed
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels May 13, 2020
@phenixblue
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2020
spiffxp
spiffxp suggested changes May 16, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and suggestions

cluster/gce/gci/configure-helper.sh Outdated Show resolved Hide resolved
cluster/gce/gci/configure-helper.sh Show resolved Hide resolved
cluster/gce/gci/configure-helper.sh Outdated Show resolved Hide resolved
cluster/gce/gci/configure-helper.sh Outdated Show resolved Hide resolved
cluster/gce/gci/configure-helper.sh Outdated Show resolved Hide resolved
cluster/gce/gci/configure-helper.sh Outdated Show resolved Hide resolved
cluster/gce/gci/configure-helper.sh Outdated Show resolved Hide resolved
@joakimr-axis joakimr-axis requested a review from spiffxp May 16, 2020 16:03
@cheftako
Copy link
Member

/lgtm

joakimr-axis and others added 15 commits June 29, 2020 08:43
@joakimr-axis
Code review update
1f9704c 
Change-Id: I384a73efe995c529fb4b3636cb9639eafb90787f
Signed-off-by: Joakim Roubert <joakimr@axis.com>
@joakimr-axis
Update after code review
3fb0d1c 
Simplified local variable declaration as suggested by phenixblue.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Updates after code review
826274c 
Add double quotes at assignments as requested by phenixblue.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Mitigate newly added shellcheck issues
0c899b2 
Issues not present when the original patch was created have now also
been fixed.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis @spiffxp
Update cluster/gce/gci/configure-helper.sh
6e85040 
Co-authored-by: Aaron Crickenberger <spiffxp@google.com>
@joakimr-axis @spiffxp
Update cluster/gce/gci/configure-helper.sh
d66456f 
Co-authored-by: Aaron Crickenberger <spiffxp@google.com>
@joakimr-axis @spiffxp
Update cluster/gce/gci/configure-helper.sh
3e21138 
Co-authored-by: Aaron Crickenberger <spiffxp@google.com>
@joakimr-axis @spiffxp
Update cluster/gce/gci/configure-helper.sh
4abf7da 
Co-authored-by: Aaron Crickenberger <spiffxp@google.com>
@joakimr-axis
Updates after review
11f6d43 
Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Add fix for run-kube-controller-manager-as-non-root
1b9e9c6 
Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
No quotes needed/wanted for CURL_RETRY_CONNREFUSED
a20a005 
Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Remove previously added '' no longer needed
196ae34 
Adapt to changes on master since the first commit here.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Sync with master
605be22 
Add fixes for newly added code.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Review update
b529485 
Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Find what fails pull-kubernetes-e2e-gce-ubuntu-containerd
0c48e0e 
Change-Id: I7919d03926880cd9c93c61a07ada645ebfe32a89
Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@joakimr-axis
Copy link
Contributor Author

There, now both shellcheck and all CI steps seem happy.

@cheftako
Copy link
Member

cheftako commented Jul 9, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@spiffxp
Copy link
Member

spiffxp commented Jul 10, 2020

/approve
🤞

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, joakimr-axis, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spiffxp
spiffxp approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see what happens

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@justaugustus justaugustus added this to the v1.20 milestone Aug 27, 2020
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-integration
(pod pending timeout)

@justaugustus
Copy link
Member

/test pull-kubernetes-integration
(pod pending timeout)

@k8s-ci-robot k8s-ci-robot merged commit fd20de8 into kubernetes:master Aug 28, 2020
@joakimr-axis joakimr-axis deleted the joakimr-axis_configure-helper.sh branch August 28, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@mml mml Awaiting requested review from mml

@cheftako cheftako Awaiting requested review from cheftako

@johscheuer johscheuer Awaiting requested review from johscheuer

@phenixblue phenixblue Awaiting requested review from phenixblue

Assignees

@cheftako cheftako

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@joakimr-axis @k8s-ci-robot @phenixblue @cheftako @spiffxp @justaugustus @johscheuer @mikedanese