New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split scheduler framework implementation into a separate pkg #91029
Comments
And we can use this chance to remove the "v1alpha1" literal from |
+1 |
Hi @ahg-g, I was hoping that maybe I can pick this up as I'm looking for my first PR :) I'll get started on this anyway and will attempt to break the package up . Will report in a few days. What should be the names of the new package? Any tips are welcome :) @Huang-Wei @alculquicondor |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
I suggest we move the interface out of @Huang-Wei @alculquicondor what do you think? |
I vote for |
|
do you also agree that we should just graduate kubernetes/enhancements#624 and consider it implemented? |
Agree. As (1) we're not maintaining a multi-versioned scheduler framework, (2) the in-tree scheduler has totally migrated to plugin-based execution path since 1.18, and (3) scheduler-plugins has provided a number of data points proving the maturity and the scheduler framework design. |
Split the scheduler framework into an interface pkg and an implementation pkg.
We can keep the interface files (interface.go, types.go, listers.go and cyclestate.go) under
scheduler/framework/v1alpha1
and move the implementation toscheduler/framework/runtime
.Ideally plugins should only depend on the interface pkg.
/cc @Huang-Wei @alculquicondor
/sig scheduling
The text was updated successfully, but these errors were encountered: