Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete framework/v1alpha1 folder and change remaining import paths #95731

Merged
merged 1 commit into from Oct 30, 2020
Merged

Delete framework/v1alpha1 folder and change remaining import paths #95731

merged 1 commit into from Oct 30, 2020

Conversation

farah
Copy link
Contributor

@farah farah commented Oct 20, 2020

What type of PR is this?
/kind cleanup
/sig scheduling

Which issue(s) this PR fixes:
FIxes #91029

Notes for reviewer

Change remaining references of pkg/scheduler/framework/v1alpha1 inside pkg/kubelet to pkg/scheduler/framework.
Delete pkg/scheduler/framework/v1alpha1 folder.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @farah. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 20, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 20, 2020
qiutongs
qiutongs approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@qiutongs qiutongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahg-g
Copy link
Member

ahg-g commented Oct 22, 2020

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2020
@ahg-g
Copy link
Member

ahg-g commented Oct 22, 2020

/assign

@farah
Copy link
Contributor Author

farah commented Oct 22, 2020

/retest

@ahg-g
Copy link
Member

ahg-g commented Oct 22, 2020

remove also from test/e2e/framework/.import-restrictions pls

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 22, 2020
@farah
Copy link
Contributor Author

farah commented Oct 22, 2020 •
edited

Also from test/e2e/framework/.import-restrictions pls

done.
/retest

@farah
Copy link
Contributor Author

farah commented Oct 22, 2020

@ahg-g

Been getting this error a few times:
ERROR: /home/prow/go/src/github.com/kubernetes/kubernetes/cluster/images/conformance/go-runner/BUILD:37:1: GoTestGenTest cluster/images/conformance/go-runner/go_default_test_/testmain.go failed (Exit 34). Note: Remote connection/protocol failed with: execution failed catastrophically UNAVAILABLE: HTTP/2 error code: NO_ERROR

not so sure if its a flake or something else.

@farah
Copy link
Contributor Author

farah commented Oct 22, 2020

/retest

@ahg-g
Copy link
Member

ahg-g commented Oct 22, 2020

can you rebase and then try to run ./hack/update-bazel.sh again?

@farah
Copy link
Contributor Author

farah commented Oct 23, 2020

/retest

@ahg-g
Copy link
Member

ahg-g commented Oct 23, 2020

/assign @dashpole

David can you please help approve this minor refactoring from kubelet side?

@ahg-g
Copy link
Member

ahg-g commented Oct 23, 2020

/approve

@dashpole
Copy link
Contributor

Sorry, I am not an approver for kubelet anymore.
/unassign
/assign @derekwaynecarr

@ahg-g
Copy link
Member

ahg-g commented Oct 28, 2020

@dims are you able to help with this one?

@ahg-g
Copy link
Member

ahg-g commented Oct 29, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2020
@ahg-g
Copy link
Member

ahg-g commented Oct 29, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 29, 2020
@ahg-g
Copy link
Member

ahg-g commented Oct 30, 2020

@Random-Liu can you please take a look?

@sjenning
Copy link
Contributor

/lgtm
/approve
for kubelet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2020
@ahg-g
Copy link
Member

ahg-g commented Oct 30, 2020

@msau42 can you please approve the test part?

@msau42
Copy link
Member

msau42 commented Oct 30, 2020

/approve
for test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, farah, msau42, qiutongs, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 332d17c into kubernetes:master Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 30, 2020
@qiutongs qiutongs mentioned this pull request Dec 9, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiutongs qiutongs qiutongs approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@rohitagarwal003 rohitagarwal003 Awaiting requested review from rohitagarwal003

Assignees

@sjenning sjenning

@derekwaynecarr derekwaynecarr

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Split scheduler framework implementation into a separate pkg
8 participants
@farah @k8s-ci-robot @ahg-g @dashpole @sjenning @msau42 @qiutongs @derekwaynecarr