-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update metrics to conform promlint #91448
update metrics to conform promlint #91448
Conversation
…tion_attempts_total as counter metrics should have _total suffix.
/test pull-kubernetes-dependencies |
/assign @logicalhan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/test pull-kubernetes-e2e-kind /assign @ahg-g |
/hold this is like deprecating and adding a new metric! |
There usually two methods for modifying a metric, especially for an alpha metric:
Seems @ahg-g like method 2, right? /cc @Huang-Wei |
/lgtm since it is an alpha metric |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, logicalhan, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
LGTM, thanks @RainbowMango. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update metrics name from
scheduler_total_preemption_attempts
toscheduler_preemption_attempts_total
as perpromlint
rules:counter metrics should have "_total" suffix
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/priority important-soon