New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deprecated description to metrics scheduling_duration_seconds #92160

Merged

k8s-ci-robot merged 1 commit into kubernetes:master from YuikoTakada:add_deprecated_description_scheduling_duration_seconds

Jul 9, 2020

Contributor

YuikoTakada commented Jun 16, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind documentation

What this PR does / why we need it:

This PR adds Deprecated description to metrics scheduling_duration_seconds.
scheduling_duration_seconds is deprecated since v1.18.
See: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#kube-scheduler

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot added release-note-none kind/documentation size/XS cncf-cla: yes needs-sig needs-priority sig/apps sig/instrumentation and removed needs-sig labels

k8s-ci-robot requested review from lichuqiang and msau42

June 16, 2020 01:17

SergeyKanzhelev reviewed

View reviewed changes

pkg/controller/volume/scheduling/metrics/metrics.go Outdated

    
            @@ -40,7 +40,7 @@ var (
          
              		&metrics.HistogramOpts{

              			Subsystem:      VolumeSchedulerSubsystem,

              			Name:           "scheduling_duration_seconds",

              			Help:           "Volume scheduling stage latency",

              			Help:           "Volume scheduling stage latency (Deprecated since 1.18.0)",

Member

SergeyKanzhelev Jun 16, 2020

nit: would be great to add it to other metrics than:

kubernetes/pkg/scheduler/metrics/metrics.go

Lines 108 to 117 in 5b3fe05

    
           DeprecatedSchedulingAlgorithmPriorityEvaluationSecondsDuration = metrics.NewHistogram( 
        
           	&metrics.HistogramOpts{ 
        
           		Subsystem:         SchedulerSubsystem, 
        
           		Name:              "scheduling_algorithm_priority_evaluation_seconds", 
        
           		Help:              "Scheduling algorithm priority evaluation duration in seconds", 
        
           		Buckets:           metrics.ExponentialBuckets(0.001, 2, 15), 
        
           		StabilityLevel:    metrics.ALPHA, 
        
           		DeprecatedVersion: "1.19.0", 
        
           	}, 
        
           )

kubernetes/pkg/scheduler/metrics/metrics.go

Lines 98 to 107 in 5b3fe05

    
           DeprecatedSchedulingAlgorithmPredicateEvaluationSecondsDuration = metrics.NewHistogram( 
        
           	&metrics.HistogramOpts{ 
        
           		Subsystem:         SchedulerSubsystem, 
        
           		Name:              "scheduling_algorithm_predicate_evaluation_seconds", 
        
           		Help:              "Scheduling algorithm predicate evaluation duration in seconds", 
        
           		Buckets:           metrics.ExponentialBuckets(0.001, 2, 15), 
        
           		StabilityLevel:    metrics.ALPHA, 
        
           		DeprecatedVersion: "1.19.0", 
        
           	}, 
        
           )

From changelog:

The scheduling_duration_seconds summary metric is deprecated (#86586, @xiaoanyunfei) [SIG Scheduling]
The scheduling_algorithm_predicate_evaluation_seconds and scheduling_algorithm_priority_evaluation_seconds metrics are deprecated, replaced by framework_extension_point_duration_seconds[extension_point="Filter"] and framework_extension_point_duration_seconds[extension_point="Score"]. (#86584, @xiaoanyunfei) [SIG Scheduling]

Contributor Author

YuikoTakada Jun 17, 2020

Thank you for your comments. I'll add them also. Are these metrics deprecated since 1.19.0? They are mentioned in CHANGELOG-1.18.md.

YuikoTakada force-pushed the add_deprecated_description_scheduling_duration_seconds branch from 5de4270 to 12865a8 Compare

June 24, 2020 06:23

k8s-ci-robot added the sig/scheduling label

YuikoTakada force-pushed the add_deprecated_description_scheduling_duration_seconds branch from 12865a8 to efb5d8c Compare

June 24, 2020 06:26

Member

msau42 commented Jun 26, 2020 •

edited

/assign @ahg-g
Does the scheduler framework provide metrics for plugins now?

k8s-ci-robot assigned ahg-g

Member

ahg-g commented Jun 26, 2020

/assign @ahg-g
Does the scheduler framework provide metrics for plugins now?

yes, we have a per extension point and per {ExtensionPoint, Plugin} metrics.

/lgtm
/approve

k8s-ci-robot added the lgtm label

Member

msau42 commented Jun 26, 2020

Looks like there are some formatting issues that need to be fixed. Otherwise, lgtm
/approve

k8s-ci-robot added the approved label

fejta-bot commented Jun 26, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

8 similar comments

fejta-bot commented Jun 27, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 27, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 27, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 27, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 27, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 27, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 27, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 28, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 29, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

16 similar comments

fejta-bot commented Jun 29, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 29, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 29, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 30, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 30, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 30, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 30, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 30, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 30, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jun 30, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jul 1, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jul 1, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jul 1, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jul 1, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jul 1, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot commented Jul 1, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.


          Add Deprecated description to metrics scheduling_duration_seconds

97bca0e

YuikoTakada force-pushed the add_deprecated_description_scheduling_duration_seconds branch from efb5d8c to 97bca0e Compare

July 2, 2020 00:15

k8s-ci-robot added size/S and removed lgtm size/XS labels

Contributor

k8s-ci-robot commented Jul 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, msau42, YuikoTakada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/controller/volume/scheduling/OWNERS~~ [msau42]
~~pkg/scheduler/OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Member

msau42 commented Jul 7, 2020

/retest

Member

SergeyKanzhelev commented Jul 8, 2020

ping @ahg-g to reapply LGTM

Member

ahg-g commented Jul 8, 2020

/lgtm

k8s-ci-robot added the lgtm label

k8s-ci-robot merged commit c2e6e14 into kubernetes:master

k8s-ci-robot added this to the v1.19 milestone

likakuli mentioned this pull request

why remove VolumeSchedulingStageLatency metrics from scheduler? #122947

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cncf-cla: yes kind/documentation lgtm needs-priority release-note-none sig/apps sig/instrumentation sig/scheduling size/S