Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #90942 from ii/ii-create-pod%2Bpodstatus-resource-lifecycle-test" #93405

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Revert "Merge pull request #90942 from ii/ii-create-pod%2Bpodstatus-resource-lifecycle-test" #93405

merged 2 commits into from
Jul 24, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 24, 2020 •
edited
Loading

This reverts commit 8e5c022 in #90942

Newly introduced test is flaking, see:

And reverts 8a3fc2d in #92589

Newly introduced test is flaking, see:

/milestone v1.19
/priority critical-urgent

NONE

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2020
@liggitt liggitt mentioned this pull request Jul 24, 2020
Merged
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/kind flake

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

cc @kubernetes/ci-signal

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jul 24, 2020
@liggitt liggitt mentioned this pull request Jul 24, 2020
Merged
@hasheddan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

Should find some time to write an updated e2e writing guide and include something like "please /test all N times and watch for flakes of your new test" 🤔

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

cc @spiffxp @Riaankl

@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/retest

@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/retest

3 similar comments
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/retest

@nikhita
Copy link
Member

nikhita commented Jul 24, 2020

/retest

@nikhita
Copy link
Member

nikhita commented Jul 24, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 607c5da into kubernetes:master Jul 24, 2020
@liggitt liggitt deleted the revert-pod-lifecycle-flake branch July 24, 2020 14:22
This was referenced Jul 27, 2020
Closed
Closed
This was referenced Aug 4, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@BenTheElder BenTheElder

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @hasheddan @BenTheElder @k8s-ci-robot @nikhita