Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Create AppsV1Deployment resource lifecycle test - +6 endpoint coverage #93458

Merged
merged 6 commits into from Nov 4, 2020
Merged

Updated Create AppsV1Deployment resource lifecycle test - +6 endpoint coverage #93458

merged 6 commits into from Nov 4, 2020

Conversation

riaankleinhans
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:
deleteAppsV1CollectionNamespacedDeployment
listAppsV1DeploymentForAllNamespaces
patchAppsV1NamespacedDeployment
patchAppsV1NamespacedDeploymentStatus
readAppsV1NamespacedDeploymentStatus
replaceAppsV1NamespacedDeploymentStatus

Which issue(s) this PR fixes:
Fixes #90916

Special notes for your reviewer:
Adds +5 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/conformance Issues or PRs related to kubernetes conformance tests needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jul 27, 2020
@BobyMCbobs BobyMCbobs force-pushed the create-deployment-resource-lifecycle-test branch from b80e068 to 5d7e3d1 Compare July 27, 2020 02:16
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2020
@BobyMCbobs
Copy link
Member

/retest

@BobyMCbobs BobyMCbobs force-pushed the create-deployment-resource-lifecycle-test branch from 945535b to 875dddf Compare July 27, 2020 04:27
@riaankleinhans riaankleinhans added this to In Progress PRs in conformance-definition Jul 27, 2020
@BobyMCbobs
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2020
@BobyMCbobs
Copy link
Member

/retest

3 similar comments
@BobyMCbobs
Copy link
Member

/retest

@BobyMCbobs
Copy link
Member

/retest

@BobyMCbobs
Copy link
Member

/retest

@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@heyste
Copy link
Member

heyste commented Nov 3, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind

3 similar comments
@heyste
Copy link
Member

heyste commented Nov 3, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind

@heyste
Copy link
Member

heyste commented Nov 3, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind

@heyste
Copy link
Member

heyste commented Nov 3, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind

@heyste
Copy link
Member

heyste commented Nov 3, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Riaankl, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@hh
Copy link
Member

hh commented Nov 3, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Riaankl: you cannot LGTM your own PR.

In response to this:

Thank you @smarterclayton
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@riaankleinhans
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@heyste
Copy link
Member

heyste commented Nov 4, 2020

/test pull-kubernetes-bazel-build
flakes

go_test: //staging/src/k8s.io/apiserver/pkg/server/filters/go_default_test:run_1_of_2 expand_less 	0s
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //staging/src/k8s.io/apiserver/pkg/server/filters:go_default_test
-----------------------------------------------------------------------------
2020/11/04 00:06:13 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0003f2068 127.0.0.1:46596 in state active
  *net.TCPConn 0xc0003f2060 127.0.0.1:46594 in state active
Terminated
-- Test timed out at 2020-11-04 00:11:06 UTC --
go_test: //staging/src/k8s.io/apiserver/pkg/server/filters/go_default_test:run_2_of_2 expand_less 	0s
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //staging/src/k8s.io/apiserver/pkg/server/filters:go_default_test
-----------------------------------------------------------------------------
2020/11/04 00:06:13 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc000186050 127.0.0.1:59230 in state active
  *net.TCPConn 0xc000186040 127.0.0.1:59226 in state active
Terminated
-- Test timed out at 2020-11-04 00:11:06 UTC --

@heyste
Copy link
Member

heyste commented Nov 4, 2020

/test pull-kubernetes-bazel-test
hit wrong test

@heyste
Copy link
Member

heyste commented Nov 4, 2020

/test pull-kubernetes-bazel-test
flake

//staging/src/k8s.io/apiserver/pkg/server/filters:go_default_test       TIMEOUT in 1 out of 2 in 315.0s
  Stats over 2 runs: max = 315.0s, min = 2.1s, avg = 158.5s, dev = 156.5s
  /bazel-scratch/.cache/bazel/_bazel_root/7989b31489f31aee54f32688da2f0120/execroot/io_k8s_kubernetes/bazel-out/k8-fastbuild/testlogs/staging/src/k8s.io/apiserver/pkg/server/filters/go_default_test/run_1_of_2/test.log
//staging/src/k8s.io/legacy-cloud-providers/vsphere:go_default_test      FAILED in 1 out of 2 in 3.2s
  Stats over 2 runs: max = 3.2s, min = 3.1s, avg = 3.1s, dev = 0.1s
  /bazel-scratch/.cache/bazel/_bazel_root/7989b31489f31aee54f32688da2f0120/execroot/io_k8s_kubernetes/bazel-out/k8-fastbuild/testlogs/staging/src/k8s.io/legacy-cloud-providers/vsphere/go_default_test/run_1_of_2/test.log

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 739768d into kubernetes:master Nov 4, 2020
conformance-definition automation moved this from In Progress PRs to Done Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 4, 2020
@riaankleinhans
Copy link
Contributor Author

Testgrid

@riaankleinhans riaankleinhans moved this from Done to Promotion PRs Needing Two Weeks (flake free) in conformance-definition Nov 4, 2020
@riaankleinhans riaankleinhans mentioned this pull request Nov 9, 2020
Closed
@riaankleinhans
Copy link
Contributor Author

Single flaky test run 7 Nov fixed by #96384

@liggitt liggitt moved this from Promotion PRs Needing Two Weeks (flake free) to Done in conformance-definition Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@foxish foxish Awaiting requested review from foxish

@kow3ns kow3ns Awaiting requested review from kow3ns

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@hh hh

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Write AppsV1Deployment resource lifecycle test - +6 endpoint coverage
9 participants
@riaankleinhans @BobyMCbobs @liggitt @heyste @hh @smarterclayton @k8s-ci-robot @fejta-bot @oomichi