Use separate pathSpec for local and remote to properly handle cleaning paths

[soltysh]

What type of PR is this?
/kind bug

What this PR does / why we need it:
We should be consistently be using https://golang.org/pkg/path/filepath/ instead of https://golang.org/pkg/path/ when working with paths.

This PR defines remotePath and localPath type which properly handles os-related operations such as cleaning, joining paths, etc.

Special notes for your reviewer:
/assign @sallyom @seans3

Does this PR introduce a user-facing change?:

NONE

/sig cli
/priority important-longterm
/milestone v1.19

[BenTheElder]

👋 happened to see this PR looking for another one ...

If paths are for use in the container they should probably use path instead of filepath, it should be good enough in general to handle POSIX paths, but if you use filepath for container paths then it will break when the client is windows.

[hasheddan]

@soltysh does this need to be in v1.19? If so, who do we need for lgtm?

[liggitt]

/hold for #94165 (comment) question

[liggitt]

/milestone v1.20

This is late for 1.19, can resolve in 1.19.x if needed

[lukehinds]

where are we with this ? as per #94165 filepath is problematic for windows, so it sounds like we need to approach this fix with a different approach?

[soltysh]

where are we with this ? as per #94165 filepath is problematic for windows, so it sounds like we need to approach this fix with a different approach?

I'm verifying all the edge cases and should have the answer today/tomorrow at latest.

[soltysh]

/retest

[liggitt]

this is not right, the pod name is either <pod> or <namespace>/<pod>, so this should continue to split on "/"

See the documented example:

kubectl cp <some-namespace>/<some-pod>:/tmp/foo /tmp/bar

If a test did not catch this, then we need to add a test explicitly for this case.

[soltysh]

We have a test here:

kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/cp/cp_test.go

Lines 55 to 112 in 28b46be

	func TestExtractFileSpec(t *testing.T) {
	tests := []struct {
	spec string
	expectedPod string
	expectedNamespace string
	expectedFile string
	expectErr bool
	}{
	{
	spec: "namespace/pod:/some/file",
	expectedPod: "pod",
	expectedNamespace: "namespace",
	expectedFile: "/some/file",
	},
	{
	spec: "pod:/some/file",
	expectedPod: "pod",
	expectedFile: "/some/file",
	},
	{
	spec: "/some/file",
	expectedFile: "/some/file",
	},
	{
	spec: ":file:not:exist:in:local:filesystem",
	expectErr: true,
	},
	{
	spec: "namespace/pod/invalid:/some/file",
	expectErr: true,
	},
	{
	spec: "pod:/some/filenamewith:in",
	expectedPod: "pod",
	expectedFile: "/some/filenamewith:in",
	},
	}
	for _, test := range tests {
	spec, err := extractFileSpec(test.spec)
	if test.expectErr && err == nil {
	t.Errorf("unexpected non-error")
	continue
	}
	if err != nil && !test.expectErr {
	t.Errorf("unexpected error: %v", err)
	continue
	}
	if spec.PodName != test.expectedPod {
	t.Errorf("expected: %s, saw: %s", test.expectedPod, spec.PodName)
	}
	if spec.PodNamespace != test.expectedNamespace {
	t.Errorf("expected: %s, saw: %s", test.expectedNamespace, spec.PodNamespace)
	}
	if spec.File != test.expectedFile {
	t.Errorf("expected: %s, saw: %s", test.expectedFile, spec.File)
	}
	}
	}

but since we're running that on a linux machine it works just fine.

[soltysh]

/retest

[soltysh]

/retest

[tallclair]

I'm really sorry I've been so delinquent on this review.

I have a few suggestions around making the path types explicit where we're expecting to be dealing with a specific path type.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[soltysh]

@tallclair @enj this should be ready for another round of reviews

[soltysh]

/remove-lifecycle stale

[tallclair]

/lgtm
/approve
🎉

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest