Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the remaining kubectl bits to k8s.io/kubectl #96190

Merged
merged 3 commits into from Nov 12, 2020
Merged

Move the remaining kubectl bits to k8s.io/kubectl #96190

merged 3 commits into from Nov 12, 2020

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Nov 3, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is culmination of the efforts from kubernetes/enhancements#1020

Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#725

Special notes for your reviewer:
/assign @pwittrock @seans3

Does this PR introduce a user-facing change?:

Introduce kubectl-convert plugin.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/1020-kubectl-staging/README.md
- [Code Organization Agenda]: https://docs.google.com/document/d/1HtTI0rJEGP_MSf6eO87aCmx_tzpovPAAg7U2Zxwm8FE/edit?ts=5c9d0a4c#bookmark=id.fqfpdy1w5idg

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 3, 2020
@soltysh soltysh mentioned this pull request Nov 3, 2020
Closed
@soltysh
Copy link
Contributor Author

soltysh commented Nov 3, 2020

/sig cli
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/kubectl and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2020
@pwittrock
Copy link
Member

/approve

@soltysh
Copy link
Contributor Author

soltysh commented Nov 4, 2020

/hold
for sufficient exposure

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@eddiezane eddiezane added this to Needs review in SIG CLI Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 6, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Nov 10, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2020
@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwittrock, smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@kikisdeliveryservice
Copy link
Member

Is this PR somehow stuck? It's been passing but tide pending for a long time now.. 🤔

@soltysh
Copy link
Contributor Author

soltysh commented Nov 12, 2020

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Nov 12, 2020

Is this PR somehow stuck? It's been passing but tide pending for a long time now.. thinking

I'm seeing problems with pkg/kubelet/cm/devicemanager mentioned in #94528
I'll keep an eye on this one.

@soltysh
Copy link
Contributor Author

soltysh commented Nov 12, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit ee0d358 into kubernetes:master Nov 12, 2020
SIG CLI automation moved this from Needs review to Done Nov 12, 2020
@soltysh soltysh deleted the kubectl_staging branch November 13, 2020 14:45
@github-actions github-actions bot mentioned this pull request Nov 18, 2020
Open
@soltysh soltysh mentioned this pull request Feb 17, 2021
Merged
@piradata
Copy link

piradata commented Apr 17, 2023 •
edited

Code Organization Agenda

this was shared as anyone with the link can edit, please change. by the way, in the end, what happened with the convert command? cant find it anywhere on the docs and there is no plugin on krew...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@seans3 seans3

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Determine what happens to the "kubectl convert" functionality
7 participants
@soltysh @pwittrock @smarterclayton @k8s-ci-robot @kikisdeliveryservice @piradata @seans3