New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename E2E storage StressTestOptions to reflect tests that consume it #96241
Comments
@chrishenzie: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig storage |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be changed:
The
StressTestOptions
field should be renamed to something specific to the tests that consume it, likeVolumeStressTestOptions
orVolumeRestartStressTestOptions
.kubernetes/test/e2e/storage/testsuites/testdriver.go
Lines 191 to 192 in 9a469d2
kubernetes/test/e2e/storage/testsuites/testdriver.go
Lines 195 to 202 in 9a469d2
Why is this needed:
Because we are adding other types of stress tests, like volume snapshot stress tests, that also require fields like
NumPods
. Placing fields for volume snapshot stress tests (likeNumSnapshots
) in this struct will restrict the ability for users to configure differentNumPods
for a volume stress test vs. a volume snapshot stress test.If we choose to place volume snapshot stress test options in a separate struct, the current struct name may be a misnomer for users when it only applies to volume stress tests.
Additional details:
When running E2E tests for external storage drivers, users can supply a
-storage.testdriver=testdriver.yaml
field which deserializes to this struct:kubernetes/test/e2e/storage/testsuites/testdriver.go
Lines 159 to 160 in 9a469d2
As an intermediate step, we may want to rename this field and modify the codec that deserializes to this struct to translate
StressTestOptions
to the new field name.kubernetes/test/e2e/storage/external/external.go
Lines 197 to 199 in 9a469d2
The text was updated successfully, but these errors were encountered: