Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage test suits for Windows #96479

Merged
merged 1 commit into from Nov 12, 2020
Merged

Update storage test suits for Windows #96479

merged 1 commit into from Nov 12, 2020

Conversation

jingxu97
Copy link
Contributor

Update storage test suits to enable some tests on Windows

Change-Id: I1f596bb9f7a0f41ae398aec43406ee5c753cdce3

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

@jingxu97: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2020
@jingxu97
Copy link
Contributor Author

/assign @Jiawei0227

@jingxu97 jingxu97 mentioned this pull request Nov 11, 2020
Closed
@jingxu97
Copy link
Contributor Author

/assign @msau42

msau42
msau42 reviewed Nov 11, 2020
View reviewed changes
test/e2e/storage/testsuites/multivolume.go Outdated
NodeSelection: node,
PVCsReadOnly: readOnly,
ImageID: e2evolume.GetTestImageId(imageutils.DebianIptables),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need to use iptables image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f2bf2ab

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dd command has some special options that busybox cannot support

test/e2e/storage/testsuites/volume_io.go
@@ -141,7 +141,7 @@ func (t *volumeIOTestSuite) DefineTests(driver TestDriver, pattern testpatterns.
l.migrationCheck.validateMigrationVolumeOpCounts()
}

ginkgo.It("should write files of various sizes, verify size, validate content [Slow]", func() {
ginkgo.It("should write files of various sizes, verify size, validate content [Slow][LinuxOnly]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make this testcase work on Windows? Should we open a tracking issue to track all the LinuxOnly test cases and see if it is possible to make it work for Windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible. But need sometime to find a way to replace those linux commands. I will open an issue for it

test/e2e/storage/utils/utils.go Outdated
}

// VerifyExecInPodSucceed verifies shell cmd in target pod succeed
func VerifyExecInPodSucceed(f *framework.Framework, pod *v1.Pod, shExec string) {
stdout, stderr, err := PodExec(f, pod, shExec)
fmt.Printf("shExec %s", shExec)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for debugging purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed. thanks!

@Jiawei0227
Copy link
Contributor

Hmm, there seems to be a build issue?

@jingxu97
Copy link
Contributor Author

Hmm, there seems to be a build issue?
Something wrong with import k8s.io/kubernetes/test/e2e/framework/pv". Not sure about the root cause, for now I will remove that dependency.

compilepkg: missing strict dependencies:
	/usr/local/google/home/jinxu/.cache/bazel/_bazel_jinxu/28e157fdac273189ba8ce989d815e18f/sandbox/linux-sandbox/3268/execroot/io_k8s_kubernetes/test/e2e/framework/volume/fixtures.go: import of "k8s.io/kubernetes/test/e2e/framework/pv"
No dependencies were provided.

@jingxu97 jingxu97 force-pushed the nov/testwindows branch 2 times, most recently from b9b1b4f to 60ed26e Compare November 11, 2020 21:44
@jingxu97
Update storage test suits for Windows
56373aa 
Update storage test suits to enable some tests on Windows

Change-Id: I1f596bb9f7a0f41ae398aec43406ee5c753cdce3
@jingxu97
Copy link
Contributor Author

finally, it passed tests. @Jiawei0227 @msau42 PTAL

@Jiawei0227
Copy link
Contributor

I think it lgtm
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0b1d94a into kubernetes:master Nov 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 12, 2020
This was referenced Feb 13, 2021
Closed
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 19, 2021
@k8s-ci-robot
Merge pull request #99220 from jingxu97/automated-cherry-pick-of-#87266-
f6ec471 
#93196-#94438-#94653-#95229-#95867-#96294-#96330-#96479-#96626-#96644-#96690-#96843-upstream-release-1.19

Automated cherry pick of 87266  93196 94438 94653 95229 95867 96294 96330 96479 96626 96644 96690 96843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@Jiawei0227 Jiawei0227

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jingxu97 @k8s-ci-robot @Jiawei0227 @msau42