Mark some storage tests as LinuxOnly #96644
Conversation
Some storage tests has commands not available in Windows. Mark them as LinuxOnly now. Will check later to see whether equivalent windows commands are available. Change-Id: I41b5668c855b2754a2e332cff4e90ebf2981aca0
k8s-ci-robot
added
size/S
|
@jingxu97: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-priority
jingxu97
added
do-not-merge/release-note-label-needed
k8s-ci-robot
removed
do-not-merge/needs-sig
k8s-ci-robot
removed
the
do-not-merge/needs-kind
k8s-ci-robot
added
area/test
sig/testing
| @@ -127,7 +127,7 @@ func (t *multiVolumeTestSuite) DefineTests(driver TestDriver, pattern testpatter | |||
| // [ node1 ] ==> [ node1 ] | |||
| // / \ <- same volume mode / \ | |||
| // [volume1] [volume2] [volume1] [volume2] | |||
| ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on the same node", func() { | |||
| ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on the same node [LinuxOnly]", func() { | |||
There was a problem hiding this comment.
Is this failing just for block volmode or also filesystem volmode?
There was a problem hiding this comment.
block test will not be triggered because pd driver for windows does not support block.
Only one negative test for blockvolume will be triggered since it is trying to test if block is not supported.
There was a problem hiding this comment.
This test case runs for both filesystem volmode and block volmode. By adding the Linux tag here, then the filesystem volmode test case will no longer run on Windows. Is that what we want?
There was a problem hiding this comment.
yes, the command used here is not available for windows no matter vol type. I need to work on finding similar commands for windows before enabling them.
| @@ -157,7 +157,7 @@ func (t *multiVolumeTestSuite) DefineTests(driver TestDriver, pattern testpatter | |||
| // [ node1 ] ==> [ node2 ] | |||
| // / \ <- same volume mode / \ | |||
| // [volume1] [volume2] [volume1] [volume2] | |||
| ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on different node", func() { | |||
| ginkgo.It("should access to two volumes with the same volume mode and retain data across pod recreation on different node [LinuxOnly]", func() { | |||
There was a problem hiding this comment.
In general, we are inconsistent with how we skip tests based on OS. Sometimes, we check node OS, and sometimes we use [LinuxOnly] tag. Can you clarify when do we use which method?
There was a problem hiding this comment.
If the tests can only work on linux, we mark it as [linuxonly]
for some tests, the test can work on Windows but with certain fstypes (not all fstypes), there is a check here
|
can you open a bug to track investigating these tests? |
y, I have one opened #96481 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some storage tests has commands not available in Windows. Mark them as
LinuxOnly now. Will check later to see whether equivalent windows
commands are available.
Change-Id: I41b5668c855b2754a2e332cff4e90ebf2981aca0
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: