Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the help text for kubelet's enable-cadvisor-json-endpoints flag to explicitly mention that it has no effect on the /stats/summary endpoint. #96928

Merged
merged 1 commit into from Dec 9, 2020
Merged

Update the help text for kubelet's enable-cadvisor-json-endpoints flag to explicitly mention that it has no effect on the /stats/summary endpoint. #96928

merged 1 commit into from Dec 9, 2020

Conversation

mysunshine92
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
Update the help text for kubelet's enable-cadvisor-json-endpoints flag to explicitly mention that it has no effect on the /stats/summary endpoint.

Which issue(s) this PR fixes:

Fixes #96483

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@mysunshine92
Update the help text for kubelet's enable-cadvisor-json-endpoints fla…
f6d7cab 
…g to explicitly mention that it has no effect on the /stats/summary endpoint.enable-cadvisor-json-endpoints
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 28, 2020
@k8s-ci-robot
Copy link
Contributor

@mysunshine92: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 28, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 28, 2020
@mysunshine92
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@mysunshine92
Copy link
Contributor Author

/assign @dchen1107

@matthyx
Copy link
Contributor

matthyx commented Nov 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2020
@mysunshine92
Copy link
Contributor Author

cc @dchen1107

@mysunshine92
Copy link
Contributor Author

cc @Random-Liu @derekwaynecarr

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, mysunshine92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@mysunshine92
Copy link
Contributor Author

cc @dchen1107 @Random-Liu @derekwaynecarr please help add /milestone v1.20, thanks.

@matthyx
Copy link
Contributor

matthyx commented Dec 2, 2020

@mysunshine92 it's not possible to add this PR to 1.20 as we are in still in the code freeze period:
https://www.kubernetes.dev/resources/release/

This change will enter master once we are in code thaw, which should happen in less than 2 weeks, and can then be backported to the 1.2x branch via cherry picking (but I don't think this commit qualifies for it):
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md

@k8s-ci-robot k8s-ci-robot merged commit 870d69e into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 9, 2020
@ehashman ehashman mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx Awaiting requested review from matthyx

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@dchen1107 dchen1107

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Document that disabling enable-cadvisor-json-endpoints flag does not disable stats summary endpoint
4 participants
@mysunshine92 @k8s-ci-robot @matthyx @dchen1107