Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 443 and 448 from cloud provider azure to 1.20 #97639

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Cherry pick 443 and 448 from cloud provider azure to 1.20 #97639

merged 1 commit into from
Jan 6, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Dec 31, 2020 •
edited by liggitt
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:
Cherry pick 443 and 448 from cloud provider azure to 1.20.
kubernetes-sigs/cloud-provider-azure#443: Use network.Interface.VirtualMachine.ID to get the binded VM.
kubernetes-sigs/cloud-provider-azure#448: Skip standalone VM when reconciling LoadBalancer.

Which issue(s) this PR fixes:

Fixes #97352
Fixes #97375

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes a regression in 1.20 to use network.Interface.VirtualMachine.ID to get the binded VM and skip standalone VM when reconciling LoadBalancer

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig cloud-provider
/area provider/azure
/priority critical-urgent
/triage accepted

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 31, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 31, 2020
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/cloudprovider labels Dec 31, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2020
@nilo19
Copy link
Member Author

nilo19 commented Jan 1, 2021

/retest

feiskyer
feiskyer reviewed Jan 3, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member

feiskyer commented Jan 4, 2021

/test pull-kubernetes-e2e-azure-disk-vmss

@nilo19
Copy link
Member Author

nilo19 commented Jan 5, 2021

/retest

2 similar comments
@nilo19
Copy link
Member Author

nilo19 commented Jan 5, 2021

/retest

@nilo19
Copy link
Member Author

nilo19 commented Jan 6, 2021

/retest

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-azure-disk-vmss

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 19a48fe into kubernetes:release-1.20 Jan 6, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-443-448-1.20 branch January 7, 2021 02:03
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@nilo19 @k8s-ci-robot @feiskyer @andyzhangx @liggitt