Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Read, Replace and Patch ReplicaSetScale test +3 endpoints #98987

Merged
merged 1 commit into from Feb 12, 2021
Merged

Write Read, Replace and Patch ReplicaSetScale test +3 endpoints #98987

merged 1 commit into from Feb 12, 2021

Conversation

Riaankl
Copy link
Contributor

@Riaankl Riaankl commented Feb 11, 2021 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:

  • replaceAppsV1NamespacedReplicaSetScale
  • readAppsV1NamespacedReplicaSetScale
  • patchAppsV1NamespacedReplicaSetScale

Which issue(s) this PR fixes:
Fixes #98920

Testgrid Link:
Testgrid

Special notes for your reviewer:
Adds +3 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/sig apps
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. area/conformance Issues or PRs related to kubernetes conformance tests needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Feb 11, 2021
@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/test pull-kubernetes-node-e2e

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/test pull-kubernetes-e2e-kind

Unrelated flake

• Failure [146.959 seconds]
[sig-storage] PersistentVolumes-local 
test/e2e/storage/utils/framework.go:23
  [Volume type: dir-link-bindmounted]
  test/e2e/storage/persistent_volumes-local.go:191
    Two pods mounting a local volume one after the other
    test/e2e/storage/persistent_volumes-local.go:253
      should be able to write from pod1 and read from pod2 [It]
      test/e2e/storage/persistent_volumes-local.go:254
      Feb 11 09:43:39.647: Unexpected error:
      
          <*errors.errorString | 0xc002da26a0>: {
              s: "pod \"pod-3c1c5dcc-be5e-4979-986d-d8d0b6bafb6e\" is not Running:|
              timed out waiting for the condition",
          }
          pod "pod-3c1c5dcc-be5e-4979-986d-d8d0b6bafb6e" is not Running: 
          timed out waiting for the condition
      occurred
      test/e2e/storage/persistent_volumes-local.go:784

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/test pull-kubernetes-node-e2e

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/assign @soltysh @mattfarina @kow3ns
This is to address 3 untested Apps endpoints

soltysh
soltysh requested changes Feb 11, 2021
View reviewed changes
test/e2e/apps/replica_set.go Outdated Show resolved Hide resolved
test/e2e/apps/replica_set.go Outdated Show resolved Hide resolved
test/e2e/apps/replica_set.go Outdated Show resolved Hide resolved
test/e2e/apps/replica_set.go Outdated Show resolved Hide resolved
test/e2e/apps/replica_set.go Outdated Show resolved Hide resolved
test/e2e/apps/replica_set.go Outdated Show resolved Hide resolved
@Riaankl Riaankl force-pushed the Riaankl_ReplicaSetScale branch 2 times, most recently from 3bef9f9 to 615af0d Compare February 11, 2021 20:36
dims
dims reviewed Feb 11, 2021
View reviewed changes
test/e2e/apps/replica_set.go Outdated Show resolved Hide resolved
dims
dims approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021 •
edited

/test pull-kubernetes-e2e-kind

Unrelated flake

Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link-bindmounted] 
One pod requesting one prebound PVC should be able to mount volume and 
write from pod1 expand_less | 2m19s
-- | --
test/e2e/storage/persistent_volumes-local.go:214 Feb 11 21:24:40.686: 
Unexpected error:     <*errors.errorString \| 0xc00055e820>: {         
s: "pod \"pod-1209164f-dd11-4868-9386-18091d3dfd3e\" is not Running: 
timed out waiting for the condition",     }     
pod "pod-1209164f-dd11-4868-9386-18091d3dfd3e" is not Running:
 timed out waiting for the condition occurred test/e2e/storage/persistent_volumes-local.go:217

dims
dims approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@dims dims left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

soltysh
soltysh approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

test/e2e/apps/replica_set.go
"fmt"
"time"

appsv1 "k8s.io/api/apps/v1"
autoscalingv1 "k8s.io/api/autoscaling/v1"
"k8s.io/apimachinery/pkg/types"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unnecessary empty line.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Riaankl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@soltysh
Copy link
Contributor

soltysh commented Feb 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@soltysh
Copy link
Contributor

soltysh commented Feb 12, 2021

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 12, 2021
@dims
Copy link
Member

dims commented Feb 12, 2021

/test pull-kubernetes-e2e-kind

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 12, 2021

/test pull-kubernetes-e2e-kind

Unrelated flake


1/5721 Tests Failed. | expand_less
-- | --
Kubernetes e2e suite: [sig-network] Proxy version v1 A set of valid responses are returned for both pod and service ProxyWithPath [Conformance] expand_less1m1stest/e2e/framework/framework.go:640 Feb 12 13:41:08.903: Pod didn't start within time out period Unexpected error:     <*errors.errorString \| 0xc0002761d0>: {         s: "timed out waiting for the condition",     }     timed out waiting for the condition occurred test/e2e/network/proxy.go:313 | Kubernetes e2e suite: [sig-network] Proxy version v1 A set of valid responses are returned for both pod and service ProxyWithPath [Conformance] expand_less | 1m1s | test/e2e/framework/framework.go:640 Feb 12 13:41:08.903: Pod didn't start within time out period Unexpected error:     <*errors.errorString \| 0xc0002761d0>: {         s: "timed out waiting for the condition",     }     timed out waiting for the condition occurred test/e2e/network/proxy.go:313
Kubernetes e2e suite: [sig-network] Proxy version v1 A set of valid responses are returned for both pod and service ProxyWithPath [Conformance] expand_less | 1m1s
test/e2e/framework/framework.go:640 Feb 12 13:41:08.903: Pod didn't start within time out period Unexpected error:     <*errors.errorString \| 0xc0002761d0>: {         s: "timed out waiting for the condition",     }     timed out waiting for the condition occurred test/e2e/network/proxy.go:313

@k8s-ci-robot k8s-ci-robot merged commit a2d5c58 into kubernetes:master Feb 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 12, 2021
This was referenced Feb 14, 2021
Closed
Closed
@Riaankl Riaankl added this to Promotion PRs Needing Two Weeks (flake free) in conformance-definition Feb 14, 2021
@spiffxp spiffxp moved this from Promotion PRs Needing Two Weeks (flake free) to Done in conformance-definition Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@soltysh soltysh soltysh approved these changes

@foxish foxish Awaiting requested review from foxish

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mattfarina mattfarina

@soltysh soltysh

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
conformance-definition
  
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Write Read, Replace and Patch ReplicaSetScale test +3 endpoints
6 participants
@Riaankl @k8s-ci-robot @soltysh @dims @mattfarina @kow3ns