Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e testing for hugepages downward api #99612

Merged
merged 1 commit into from Mar 6, 2021
Merged

e2e testing for hugepages downward api #99612

merged 1 commit into from Mar 6, 2021

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Mar 1, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add e2e testing for hugepages in downward API.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Related KEP:
kubernetes/enhancements#2352

Usage of hugepages requires cpu or memory are specified to pass validation.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2053-downward-api-hugepages

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2021
@derekwaynecarr
Copy link
Member Author

I am hoping either of the following can assist here with review.

/assign @liggitt
/assign @tallclair

@derekwaynecarr
Copy link
Member Author

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
sjenning
sjenning suggested changes Mar 1, 2021
View reviewed changes
test/e2e/common/downwardapi.go Outdated
}
// Important: we allow for 0 so the test passes in environments where no hugepages are allocated.
expectations := []string{
"HUGEPAGES_LIMIT=[0-9]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this would only pass on nodes with 0-9 allocated hugepages. What if there are more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I think this can be tightened to 0 or [1-9]*

@sjenning sjenning mentioned this pull request Mar 2, 2021
Closed
6 tasks
@desponda
Copy link

desponda commented Mar 4, 2021

👋 Hello! I am from the Bug Triage team! Friendly reminder that code freeze is starting March 9th, 2021 (about 1 week from now). We want to ensure that each PR has a chance to be merged before code freeze.
As the PR is tagged for 1.21, is it still planned for this release?

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 4, 2021
@sjenning
Copy link
Contributor

sjenning commented Mar 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@SergeyKanzhelev SergeyKanzhelev added this to PRs - Review in progress in SIG Node CI/Test Board Mar 4, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 4, 2021
ehashman
ehashman reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-soon
/triage accepted

test/e2e/common/node/downwardapi.go Outdated
@@ -283,6 +283,109 @@ var _ = SIGDescribe("Downward API", func() {
})
})

var _ = framework.KubeDescribe("Downward API [Serial] [Disruptive] [NodeFeature:DownwardAPIHugePages]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SIGDescribe instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KubeDescribe no longer exists after: #99700

Please use SIGDescribe as Elana suggested.

test/e2e/common/node/downwardapi.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 4, 2021
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 4, 2021
@derekwaynecarr
Copy link
Member Author

oops, pushed a mess when addressing a rebase conflict.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Mar 5, 2021

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@ehashman ehashman moved this from PRs - Review in progress to Done in SIG Node CI/Test Board Mar 5, 2021
@ehashman ehashman moved this from Waiting on Author to Done in SIG Node PR Triage Mar 5, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a954818 into kubernetes:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@sjenning sjenning sjenning requested changes

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

Assignees

@sjenning sjenning

@liggitt liggitt

@wojtek-t wojtek-t

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@derekwaynecarr @desponda @sjenning @wojtek-t @k8s-ci-robot @fejta-bot @ehashman @liggitt @tallclair