-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e testing for hugepages downward api #99612
e2e testing for hugepages downward api #99612
Conversation
I am hoping either of the following can assist here with review. /assign @liggitt |
/milestone v1.21 |
test/e2e/common/downwardapi.go
Outdated
} | ||
// Important: we allow for 0 so the test passes in environments where no hugepages are allocated. | ||
expectations := []string{ | ||
"HUGEPAGES_LIMIT=[0-9]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this would only pass on nodes with 0-9 allocated hugepages. What if there are more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I think this can be tightened to 0 or [1-9]*
👋 Hello! I am from the Bug Triage team! Friendly reminder that code freeze is starting March 9th, 2021 (about 1 week from now). We want to ensure that each PR has a chance to be merged before code freeze. |
8c586ff
to
c52c48e
Compare
c52c48e
to
c8a697f
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/priority important-soon
/triage accepted
test/e2e/common/node/downwardapi.go
Outdated
@@ -283,6 +283,109 @@ var _ = SIGDescribe("Downward API", func() { | |||
}) | |||
}) | |||
|
|||
var _ = framework.KubeDescribe("Downward API [Serial] [Disruptive] [NodeFeature:DownwardAPIHugePages]", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use SIGDescribe instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KubeDescribe no longer exists after: #99700
Please use SIGDescribe as Elana suggested.
oops, pushed a mess when addressing a rebase conflict. |
c8a697f
to
6215b12
Compare
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add e2e testing for hugepages in downward API.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Related KEP:
kubernetes/enhancements#2352
Usage of hugepages requires cpu or memory are specified to pass validation.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: