Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rev ES and allow anonymous access to kibana #100169

Merged
merged 1 commit into from May 14, 2021
Merged

rev ES and allow anonymous access to kibana #100169

merged 1 commit into from May 14, 2021

Conversation

coffeepac
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

bumps elasticsearch and kibana to latest oss versions
adds rolebinding to allow anonymous access to kibana dashboard.

  • this isn't intended to be a production-quality configuration, we should let users be able to get into their data immediately.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2021
@coffeepac
Copy link
Contributor Author

/triage accepted
/priority low
/sig instrumentation

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

@coffeepac: The label(s) priority/low cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted
/priority low
/sig instrumentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 12, 2021
@coffeepac
Copy link
Contributor Author

/assign @monotek

@coffeepac
Copy link
Contributor Author

/remove-area dependency
/remove-area provider/gcp

@k8s-ci-robot k8s-ci-robot removed area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider labels Mar 19, 2021
monotek
monotek approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2021
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2021
@coffeepac
Copy link
Contributor Author

@monotek this never got merged for some reason. I've fixed the rebase conflict. lemme know if you want to merge this or close and re-open against the future location.

@monotek monotek mentioned this pull request May 14, 2021
Merged
@monotek
Copy link
Member

monotek commented May 14, 2021 •
edited

@coffeepac

Lets merge it here.
I've added a link to my pr in kubernetes-sigs/instrumentation-addons#1 to pickup the changes later :)

@monotek
Copy link
Member

monotek commented May 14, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ee9f365 into kubernetes:master May 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 14, 2021
liggitt
liggitt reviewed May 14, 2021
View reviewed changes
cluster/addons/fluentd-elasticsearch/kibana-deployment.yaml
Comment on lines +78 to +80
subjects:
- kind: User
name: system:anonymous
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permission grants to anonymous users are not expected in these addons. revert opened in #102010

@monotek monotek mentioned this pull request May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@monotek monotek monotek approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@serathius serathius Awaiting requested review from serathius

Assignees

@monotek monotek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coffeepac @k8s-ci-robot @monotek @liggitt