Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "rev ES and allow anonymous access to kibana" #102010

Closed
wants to merge 1 commit into from
Closed

Revert "rev ES and allow anonymous access to kibana" #102010

wants to merge 1 commit into from

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 14, 2021

This reverts commit aba965b.

Anonymous permissions granted by default are not expected in the addons dir.

What type of PR is this?

/kind bug

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2021
@liggitt liggitt mentioned this pull request May 14, 2021
Merged
@k8s-ci-robot
Copy link
Contributor

@liggitt: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 14, 2021
@liggitt
Copy link
Member Author

liggitt commented May 14, 2021

/cc @coffeepac @monotek

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 14, 2021
@liggitt
Copy link
Member Author

liggitt commented May 14, 2021

/sig instrumentation

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021
@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2021
@liggitt
Copy link
Member Author

liggitt commented May 14, 2021

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented May 14, 2021

/retest

monotek
monotek suggested changes May 14, 2021
View reviewed changes
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the inconvenience approving: #100169

Could we please just remove the rbac part and keep the image update and so on?

@liggitt
Copy link
Member Author

liggitt commented May 14, 2021

Could we please just remove the rbac part and keep the image update and so on?

that's fine, can you open a PR dropping the RBAC changes?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2021
@monotek
Copy link
Member

monotek commented May 14, 2021

Sure, will do :)

@monotek monotek mentioned this pull request May 14, 2021
Merged
@monotek
Copy link
Member

monotek commented May 14, 2021

Done in: #102018

@liggitt
Copy link
Member Author

liggitt commented May 14, 2021

/close

in favor of #102018

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

/close

in favor of #102018

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt liggitt deleted the es-anonymous branch September 13, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monotek monotek monotek requested changes

@andyxning andyxning Awaiting requested review from andyxning

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@coffeepac coffeepac Awaiting requested review from coffeepac

Assignees

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @dashpole @monotek