Fix structured logs for pkg/kubelet/network/dns/dns.go #100393
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubelet
sig/network
adisky
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
bboreham
reviewed
Mar 19, 2021
k8s-ci-robot
added
size/S
adisky
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
serathius
reviewed
Mar 19, 2021
pkg/kubelet/network/dns/dns.go
Outdated
| log := fmt.Sprintf("Search Line limits were exceeded, some search paths have been omitted, the applied search line is: %s", strings.Join(composedSearch, " ")) | ||
| c.recorder.Event(pod, v1.EventTypeWarning, "DNSConfigForming", log) | ||
| klog.ErrorS(nil, "eventlog", log) | ||
| log := fmt.Errorf("Search Line limits were exceeded, some search paths have been omitted, the applied search line is: %s", strings.Join(composedSearch, " ")) |
There was a problem hiding this comment.
can we change the name to avoid confusion?
Suggested change
| log := fmt.Errorf("Search Line limits were exceeded, some search paths have been omitted, the applied search line is: %s", strings.Join(composedSearch, " ")) | |
| err := fmt.Errorf("Search Line limits were exceeded, some search paths have been omitted, the applied search line is: %s", strings.Join(composedSearch, " ")) |
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
ehashman
reviewed
Mar 19, 2021
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
lgtm
|
/milestone v1.21 Small change that fixes a bug introduced by structured logging migration. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adisky, derekwaynecarr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest k8s.io/kubernetes/test/integration/apiserver/admissionwebhook: TestMutatingWebhookResetsInvalidManagedFields |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix structured logs for pkg/kubelet/network/dns/dns.go
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is caught by the linter update we are doing here kubernetes/klog#229, Its also to make sure we are adding correct checks in linter.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig instrumentation