Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Automated cherry pick of #97417: fix azure file secret not found issue" #100397

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Revert "Automated cherry pick of #97417: fix azure file secret not found issue" #100397

merged 1 commit into from
Mar 31, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Mar 19, 2021 •
edited by liggitt
Loading

Reverts #97453

Reverts breaking change to inline AzureFile volumes in v1.18.15-v1.18.17; referenced secrets are now correctly searched for in the same namespace as the pod as in previous releases.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 19, 2021
@andyzhangx
Copy link
Member Author

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 19, 2021
@andyzhangx
Copy link
Member Author

/kind bug
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted
fixed #99061

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 19, 2021
@liggitt
Copy link
Member

liggitt commented Mar 23, 2021

/lgtm

are the aks/azure CI jobs failing in general, or only on this PR?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@liggitt liggitt added kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 23, 2021
@liggitt liggitt removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 23, 2021
@liggitt
Copy link
Member

liggitt commented Mar 23, 2021

/assign @msau42

@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@msau42
Copy link
Member

msau42 commented Mar 25, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-azure-file-windows 3ddf61d link /test pull-kubernetes-e2e-azure-file-windows
pull-kubernetes-e2e-aks-engine-azure-file 3ddf61d link /test pull-kubernetes-e2e-aks-engine-azure-file
pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim 3ddf61d link /test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member

liggitt commented Mar 29, 2021

/skip

@liggitt
Copy link
Member

liggitt commented Mar 29, 2021

/retest

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 31, 2021
@liggitt
Copy link
Member

liggitt commented Mar 31, 2021

@kubernetes/release-managers this is ready and required to fix a regression introduced in v1.18.15

hasheddan
hasheddan approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 31, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 31, 2021
@liggitt
Copy link
Member

liggitt commented Mar 31, 2021

Pending — Not mergeable. Job pull-kubernetes-e2e-azure-file-windows has not succeeded.

Looks like tide requires this. This needs to be resolved (either by fixing the job or by making it optional) to ensure this regression fix is merged asap.

@dims
Copy link
Member

dims commented Mar 31, 2021

/skip

@k8s-ci-robot k8s-ci-robot merged commit a39c389 into kubernetes:release-1.18 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@liggitt liggitt

@msau42 msau42

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andyzhangx @liggitt @msau42 @k8s-ci-robot @dims @hasheddan