Be more judicious about cleaning up service account tokens #10041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lavalamp PTAL |
liggitt
force-pushed
the
token_delete_live_check
branch
from
0e9a4d5
to
1d3dca6
Compare
|
GCE e2e build/test passed for commit 0e9a4d52ec271090e5dadb0c73ac862d4ce91f31. |
|
GCE e2e build/test passed for commit 1d3dca67962272b82610571a9619d97daf343ed4. |
| @@ -24,6 +24,8 @@ import ( | |||
| "io/ioutil" | |||
| "strings" | |||
|
|
|||
| "github.com/golang/glog" | |||
|
|
|||
There was a problem hiding this comment.
nit: this and jwt-go should be in the same block, and they should be after the kubernetes imports.
|
just a few pedantic comments... |
liggitt
force-pushed
the
token_delete_live_check
branch
from
1d3dca6
to
1ee5578
Compare
|
LGTM |
lavalamp
added
the
lgtm
|
GCE e2e build/test passed for commit 1ee5578. |
|
Merging since this fixes a bug. |
satnam6502
added a commit
that referenced
this pull request
Jun 19, 2015
Be more judicious about cleaning up service account tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we moved some of our controllers to use service account credentials to run, we ran into a bug (openshift/origin#3298) where the token controller was "cleaning up" tokens it didn't find a service account for. As a result, those controllers' reflectors API calls started failing.
Somehow, the service account whose addition to the
serviceAccountsstore triggered token creation is missing from the same store when the secret addition is observed. @deads2k, @smarterclayton and I are still trying to figure out how that is possible, but in the meantime, this PR: