-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KUBE_BUILD_CONFORMANCE on package-tarballs target #100571
Add KUBE_BUILD_CONFORMANCE on package-tarballs target #100571
Conversation
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@puerco: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
this is likely the best low-touch / smallest patch for this, but we may need to come back and consider reverting the related change to release.sh (in which case this patch will still be safe & reasonable to have)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
/test pull-kubernetes-e2e-kind |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims, hasheddan, justaugustus, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
During the
v1.21.0-beta0
andv1.21.0-rc.0
the conformance images were not being created. This PR modifies the Makefile to passKUBE_BUILD_CONFORMANCE=y
to the package-tarballs target to enable building the conformance tarballs.Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net
Which issue(s) this PR fixes:
Follow up to #100251
Special notes for your reviewer:
Slack ref: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1616708843119100?thread_ts=1616684931.106200&cid=CJH2GBF7Y
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: