Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KUBE_BUILD_CONFORMANCE on package-tarballs target #100571

Merged
merged 1 commit into from Mar 26, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Mar 26, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

During the v1.21.0-beta0 and v1.21.0-rc.0 the conformance images were not being created. This PR modifies the Makefile to pass KUBE_BUILD_CONFORMANCE=y to the package-tarballs target to enable building the conformance tarballs.

Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net

Which issue(s) this PR fixes:

Follow up to #100251

Special notes for your reviewer:

Slack ref: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1616708843119100?thread_ts=1616684931.106200&cid=CJH2GBF7Y

Does this PR introduce a user-facing change?

Pass `KUBE_BUILD_CONFORMANCE=y` to the package-tarballs to reenable building the conformance tarballs.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added release-note kind/bug size/XS do-not-merge/needs-sig labels Mar 26, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 26, 2021

@puerco: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage needs-priority cncf-cla: yes labels Mar 26, 2021
@puerco
Copy link
Member Author

@puerco puerco commented Mar 26, 2021

/sig release

@k8s-ci-robot k8s-ci-robot added sig/release and removed do-not-merge/needs-sig labels Mar 26, 2021
Copy link
Member

@BenTheElder BenTheElder left a comment

/lgtm
/approve

this is likely the best low-touch / smallest patch for this, but we may need to come back and consider reverting the related change to release.sh (in which case this patch will still be safe & reasonable to have)

@BenTheElder BenTheElder added this to the v1.21 milestone Mar 26, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 26, 2021
@BenTheElder BenTheElder added the priority/critical-urgent label Mar 26, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority label Mar 26, 2021
@BenTheElder BenTheElder added the needs-priority label Mar 26, 2021
@k8s-ci-robot k8s-ci-robot added the approved label Mar 26, 2021
@BenTheElder BenTheElder added triage/accepted and removed needs-priority needs-triage labels Mar 26, 2021
Copy link
Member

@hasheddan hasheddan left a comment

/lgtm

@dims
Copy link
Member

@dims dims commented Mar 26, 2021

/approve
/lgtm

@justaugustus justaugustus added this to In Progress (Issues & PRs) in Release Engineering via automation Mar 26, 2021
@justaugustus
Copy link
Member

@justaugustus justaugustus commented Mar 26, 2021

/test pull-kubernetes-e2e-kind
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, hasheddan, justaugustus, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9af6f70 into kubernetes:master Mar 26, 2021
13 of 14 checks passed
Release Engineering automation moved this from In Progress (Issues & PRs) to Done (1.21) Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes kind/bug lgtm priority/critical-urgent release-note sig/release size/XS triage/accepted
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants