Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providerless tag for client go auth plugins #100606

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Providerless tag for client go auth plugins #100606

merged 1 commit into from
Mar 29, 2021

Conversation

dims
Copy link
Member

@dims dims commented Mar 29, 2021 •
edited
Loading

client-go auth plugins are another vector to pull in cloud specific code when they are not needed at all. So ensure that the existing providerless tag is honored. This gets rid of the gcp/openstack/azure built-in auth plugins.

/kind bug
/release-note-none

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2021
@dims dims force-pushed the providerless-tag-for-client-go-auth-plugins branch from 3adb87f to a5a1d23 Compare March 29, 2021 00:06
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 29, 2021
@dims
providerless tag for client-go auth plugins
1ac2d6f 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the providerless-tag-for-client-go-auth-plugins branch from a5a1d23 to 1ac2d6f Compare March 29, 2021 00:08
@dims dims changed the title [WIP] Providerless tag for client go auth plugins Providerless tag for client go auth plugins Mar 29, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2021
@dims
Copy link
Member Author

dims commented Mar 29, 2021

/assign @liggitt
/area code-organization

@k8s-ci-robot k8s-ci-robot added the area/code-organization Issues or PRs related to kubernetes code organization label Mar 29, 2021
@dims
Copy link
Member Author

dims commented Mar 29, 2021

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 29, 2021
@dims
Copy link
Member Author

dims commented Mar 29, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 29, 2021
@liggitt
Copy link
Member

liggitt commented Mar 29, 2021

/lgtm

@liggitt
Copy link
Member

liggitt commented Mar 29, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@dims
Copy link
Member Author

dims commented Mar 29, 2021 •
edited
Loading

@kubernetes/release-managers @kubernetes/release-team-leads please consider this for merge right away. the providerless tag contract is broken otherwise. please add milestone v1.21 if appropriate.

@palnabarun
Copy link
Member

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 26fc02a into kubernetes:master Mar 29, 2021
This was referenced Mar 30, 2021
Closed
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 30, 2021
This was referenced Mar 31, 2021
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 1, 2021
@k8s-ci-robot
Merge pull request #100718 from dims/automated-cherry-pick-of-#100606-#…
1b217e5 
…100660-upstream-release-1.21-take-2

Automated cherry pick of #100606 #100660 upstream release 1.21
@github-actions github-actions bot mentioned this pull request Apr 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @liggitt @k8s-ci-robot @palnabarun @fedebongio