Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align lifecylce related test pod start up times #100785

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Align lifecylce related test pod start up times #100785

merged 1 commit into from
Apr 4, 2021

Conversation

jsturtevant
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It was noticed some of the pods start up times are different across the tests. This aligns the ones for the tests in #100047. See

#100047 (comment)

Which issue(s) this PR fixes:

Fixes #
only mitigates some types of failures in #100047

Special notes for your reviewer:

There are many different timeout set in many different places: #100047 (comment)

It felt to risky to change ones other than the ones that came up in #100047

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @soltysh

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 2, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and enisoc April 2, 2021 18:36
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 2, 2021
@jsturtevant
Copy link
Contributor Author

issue didn't look related, opened: #100789

/retest

@aojea
Copy link
Member

aojea commented Apr 3, 2021

/assign @wojtek-t @spiffxp

soltysh
soltysh approved these changes Apr 4, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GustavoRSSilva, jsturtevant, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thejoycekung
Copy link
Contributor

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 4, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit f137c47 into kubernetes:master Apr 4, 2021
@palnabarun palnabarun mentioned this pull request Apr 5, 2021
Merged
@palnabarun
Copy link
Member

Cherrypick filed: #100810

k8s-ci-robot added a commit that referenced this pull request Apr 5, 2021
@k8s-ci-robot
Merge pull request #100810 from palnabarun/automated-cherry-pick-of-#…
952908a 
…100785-upstream-release-1.21

Automated cherry pick of #100785: align some of the pod start up times
@jsturtevant jsturtevant mentioned this pull request Apr 5, 2021
Closed
@thejoycekung thejoycekung mentioned this pull request Apr 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@GustavoRSSilva GustavoRSSilva GustavoRSSilva approved these changes

@dims dims Awaiting requested review from dims

@enisoc enisoc Awaiting requested review from enisoc

Assignees

@spiffxp spiffxp

@soltysh soltysh

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
10 participants
@jsturtevant @aojea @k8s-ci-robot @thejoycekung @fejta-bot @palnabarun @soltysh @GustavoRSSilva @spiffxp @wojtek-t