-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn user for runtime support of debug targeting #101074
Warn user for runtime support of debug targeting #101074
Conversation
@verb: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
7773ef1
to
7d1d595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you!
Add a warning message to `kubectl debug` when using the `--target` option as many runtimes don't support it yet.
7d1d595
to
968185e
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddiezane, rikatz, verb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
Add a warning message to
kubectl debug
when using the--target
option as many runtimes don't support it yet.What type of PR is this?
/kind documentation
/sig cli
/priority important-soon
What this PR does / why we need it:
Many container runtimes (e.g. containerd) don't implement support for process namespace target required for
kubectl debug --target
to work. This adds a warning message which we can remove after the major runtimes add support and we (potentially) add the feature to runtime qualification.Which issue(s) this PR fixes:
Fixes #98362
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: