Continue on #9754, Improvements to the guestbook README, switch to .yaml files #10204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of open issues; switch to .yaml config files.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
LGTM thanks! |
|
GCE e2e build/test passed for commit 347085ba6be2cc973f1c461bee7e714134e74040. |
caesarxuchao
force-pushed
the
pr/9754/head
branch
from
347085b
to
59b654c
Compare
|
GCE e2e build/test passed for commit 59b654c. |
j3ffml
added
the
lgtm
j3ffml
added a commit
that referenced
this pull request
Jun 23, 2015
Continue on #9754, Improvements to the guestbook README, switch to .yaml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a commit to fix Shippable in #9754 as @amygdala cannot log in to Shippable. Thank you @amygdala for your contribution.
@nikhiljindal, I've given #9754 LGTM, could you give a LGTM for this PR after shippable is green? Thanks.