Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the guestbook README, switch to .yaml files #9754

Merged
merged 1 commit into from Jun 23, 2015

Conversation

amygdala
Copy link
Contributor

Improvements to the guestbook example README, + addressed a number of friction issues.
Addresses: #9520, #9421, #8859.
Switched from .json to .yaml, updated the kubectl output listings to be consistent with 0.19.
Also made some changes to help towards #9107 ("Guestbook Key Examples Needs To Work With Core Kubernetes"), though we still need more here.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Jun 12, 2015

GCE e2e build/test passed for commit 7aaeca9a0525f31ff829c2940e079a3b43b1ad4d.

@amygdala
Copy link
Contributor Author

Re: the CLA -- I added my google email to my GH profile. With that email, I'm indeed listed as being covered by the Google Corporate CLA. However, I did this commit using a different (personal) email address. I'm basically set, but not sure how to make the bot happy. In future I'll use the google addr for commits. (this is amyu@)

@amygdala
Copy link
Contributor Author

Since this is just example code, I assume the Shippable failure is some artifact of its setup?

@k8s-bot
Copy link

k8s-bot commented Jun 14, 2015

GCE e2e build/test passed for commit c0806b827d03903d493a07c609314ea966c081f3.



[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/examples/guestbook/README.md?pixel)]()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this line. I think Shippable is complaining about missing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-added it, but unfortunately, Shippable still seems to be complaining.

@k8s-bot
Copy link

k8s-bot commented Jun 21, 2015

GCE e2e build/test passed for commit 9fcc26cd6a8d8cb4da59ea673421572312bc4a31.

@amygdala amygdala force-pushed the gbupdates branch 3 times, most recently from 1996ae3 to a9e5392 Compare June 22, 2015 04:19
@k8s-bot
Copy link

k8s-bot commented Jun 22, 2015

GCE e2e build/test passed for commit 52b97859c500f447529477400b9a1206e9f79e5c.

@k8s-bot
Copy link

k8s-bot commented Jun 22, 2015

GCE e2e build/test passed for commit 1996ae37d271ba5926e1a911259a036f9cb2864e.

@amygdala amygdala added cla: yes and removed cla: no labels Jun 22, 2015
@amygdala
Copy link
Contributor Author

Thank you, @caesarxuchao. I've addressed everything aside from one question related to the type: LoadBalancer explanation. We are going to need to re-flip the cla label again when we're all set (I believe it's doing this b/c my initial PR submit was not with my google email address).

@k8s-bot
Copy link

k8s-bot commented Jun 22, 2015

GCE e2e build/test passed for commit a9e53928fa4cce2fdb93a87760685dd18e4d2458.

…er of open issues; switch to .yaml config files.
@amygdala
Copy link
Contributor Author

@caesarxuchao okay, done (& re-squashed). I made that last yaml listing change in the README, as well as the other wording change you suggested.

@k8s-bot
Copy link

k8s-bot commented Jun 22, 2015

GCE e2e build/test passed for commit 22f1b07.

@caesarxuchao
Copy link
Member

Thank you @amygdala. Could you fix the failed tests as suggested by Shippable? I think the problem is that you change the .json files to .yaml, but the tests are still looking for .json.

@amygdala
Copy link
Contributor Author

@caesarxuchao I don't know how to do that, actually. (clicking on the 'details' link for the failed build just redirects to https://app.shippable.com/ for some reason). Do you know what needs to be changed?

@caesarxuchao
Copy link
Member

Does the website ask you to sign in? You should be able to sign in with your github account.

@j3ffml j3ffml merged commit 22f1b07 into kubernetes:master Jun 23, 2015
j3ffml added a commit that referenced this pull request Jun 23, 2015
Continue on #9754, Improvements to the guestbook README, switch to .yaml files
@amygdala amygdala deleted the gbupdates branch March 10, 2016 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants