-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the guestbook README, switch to .yaml files #9754
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
GCE e2e build/test passed for commit 7aaeca9a0525f31ff829c2940e079a3b43b1ad4d. |
Re: the CLA -- I added my google email to my GH profile. With that email, I'm indeed listed as being covered by the Google Corporate CLA. However, I did this commit using a different (personal) email address. I'm basically set, but not sure how to make the bot happy. In future I'll use the google addr for commits. (this is amyu@) |
Since this is just example code, I assume the Shippable failure is some artifact of its setup? |
GCE e2e build/test passed for commit c0806b827d03903d493a07c609314ea966c081f3. |
|
||
|
||
[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/examples/guestbook/README.md?pixel)]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this line. I think Shippable is complaining about missing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-added it, but unfortunately, Shippable still seems to be complaining.
GCE e2e build/test passed for commit 9fcc26cd6a8d8cb4da59ea673421572312bc4a31. |
1996ae3
to
a9e5392
Compare
GCE e2e build/test passed for commit 52b97859c500f447529477400b9a1206e9f79e5c. |
GCE e2e build/test passed for commit 1996ae37d271ba5926e1a911259a036f9cb2864e. |
Thank you, @caesarxuchao. I've addressed everything aside from one question related to the type: LoadBalancer explanation. We are going to need to re-flip the cla label again when we're all set (I believe it's doing this b/c my initial PR submit was not with my google email address). |
GCE e2e build/test passed for commit a9e53928fa4cce2fdb93a87760685dd18e4d2458. |
…er of open issues; switch to .yaml config files.
@caesarxuchao okay, done (& re-squashed). I made that last yaml listing change in the README, as well as the other wording change you suggested. |
GCE e2e build/test passed for commit 22f1b07. |
Thank you @amygdala. Could you fix the failed tests as suggested by Shippable? I think the problem is that you change the .json files to .yaml, but the tests are still looking for .json. |
@caesarxuchao I don't know how to do that, actually. (clicking on the 'details' link for the failed build just redirects to https://app.shippable.com/ for some reason). Do you know what needs to be changed? |
Does the website ask you to sign in? You should be able to sign in with your github account. |
Continue on #9754, Improvements to the guestbook README, switch to .yaml files
Improvements to the guestbook example README, + addressed a number of friction issues.
Addresses: #9520, #9421, #8859.
Switched from .json to .yaml, updated the kubectl output listings to be consistent with 0.19.
Also made some changes to help towards #9107 ("Guestbook Key Examples Needs To Work With Core Kubernetes"), though we still need more here.