New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NodeAuthenticator tests in dual stack #103050
Fix NodeAuthenticator tests in dual stack #103050
Conversation
Hi @ardaguclu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test This is consistent with the other tests kubernetes/test/e2e/network/conntrack.go Lines 108 to 121 in 99c35dc
assumes that daemons runs always in the first ip family of the cluster, if configured for dual-stack |
@sttts could you please take a look?, thanks |
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…03050-upstream-release-1.21 Automated cherry pick of #103050: Fix NodeAuthenticator tests in dual stack
What type of PR is this?
/kind bug
What this PR does / why we need it:
NodeAuthenticator tests are failing in dualstack.
Special notes for your reviewer:
In dualstack, nodes have both IPv4 and IPv6 ip addresses assigned. But Kubelet starts metrics server just picking one of them(first one in the
--node-ip
). However, NodeAuthenticator tests try to send requests to all of IP addresses and these tests are failing in dualstack. This PR filters node IPs according to the first IP family(which kubelet starts server to listen).