Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flushlogs not working together with exit in staging repos #104776

Closed
wants to merge 1 commit into from
Closed

fix flushlogs not working together with exit in staging repos #104776

wants to merge 1 commit into from

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Sep 5, 2021

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix flushlogs not working together with exit in staging repos

Which issue(s) this PR fixes:

Fixes ##102231

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 5, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Sep 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 5, 2021
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2021
@caesarxuchao
Copy link
Member

/assign @cheftako
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2021
sanposhiho
sanposhiho reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping

Also, in this PR, please check the below.
#104775 (comment)

@kerthcet kerthcet force-pushed the bug/fix-staging-repo-log-defer-conflict-with-exit branch from cfa72fd to 49ed3ce Compare September 9, 2021 06:18
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2021
@kerthcet kerthcet force-pushed the bug/fix-staging-repo-log-defer-conflict-with-exit branch from 49ed3ce to 5a8c6bb Compare September 9, 2021 06:26
@tallclair
Copy link
Member

/approve

@kerthcet kerthcet force-pushed the bug/fix-staging-repo-log-defer-conflict-with-exit branch from 4f57d27 to b35eec2 Compare September 29, 2021 18:07
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2021
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kerthcet kerthcet force-pushed the bug/fix-staging-repo-log-defer-conflict-with-exit branch from b35eec2 to cb5196f Compare October 1, 2021 12:32
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2021
@dougsland
Copy link
Member

@kerthcet could you please rebase?

@dougsland dougsland mentioned this pull request Oct 3, 2021
Closed
@kerthcet kerthcet force-pushed the bug/fix-staging-repo-log-defer-conflict-with-exit branch from cb5196f to 45b5522 Compare October 4, 2021 05:24
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 4, 2021
@dashpole
Copy link
Contributor

dashpole commented Oct 5, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole, kerthcet, tallclair
To complete the pull request process, please ask for approval from cheftako after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kerthcet
Copy link
Member Author

kerthcet commented Oct 8, 2021

kindly ping @dims

cheftako
cheftako reviewed Oct 12, 2021
View reviewed changes
staging/src/k8s.io/component-base/logs/example/cmd/logger.go
errs := o.Validate()
if len(errs) != 0 {
fmt.Fprintf(os.Stderr, "%v\n", errs)
os.Exit(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

kubernetes/vendor/google.golang.org/grpc/internal/grpclog/grpclog.go

Line 66 in 82da9bd

os.Exit(1)
calls exit. Its the root of all glog.Fatal calls. Our leader election and other pieces of code rely on the Exit() call. So not sure this is going to completely work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct me if not, os.Exit(1) is the expected behavior if glog.Fatal calls, but we should not exit when error or warning happens, so I think this refactor has some meanings more or less.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2021
@kerthcet
remove os.Exit() in staging repos
ea8805a 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the bug/fix-staging-repo-log-defer-conflict-with-exit branch from 45b5522 to ea8805a Compare January 7, 2022 03:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 28, 2022
@kerthcet kerthcet closed this Aug 24, 2022
@kerthcet kerthcet deleted the bug/fix-staging-repo-log-defer-conflict-with-exit branch August 24, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@sanposhiho sanposhiho sanposhiho left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees

@cheftako cheftako

@dashpole dashpole

@tallclair tallclair

@sanposhiho sanposhiho

Labels
area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
SIG Auth
Archived in project
SIG Auth Old
In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@kerthcet @caesarxuchao @pacoxu @tallclair @k8s-ci-robot @dougsland @dashpole @k8s-triage-robot @cheftako @sanposhiho