Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VolumeSubpath feature gate #105090

Merged
merged 1 commit into from Sep 17, 2021

Conversation

@saad-ali
Copy link
Member

@saad-ali saad-ali commented Sep 17, 2021

What type of PR is this?

/kind cleanup

/kind deprecation

What this PR does / why we need it:

Remove the VolumeSubpath feature gate.

Per @liggitt:

Feature gate convention has been updated since this feature gate was introduced to indicate that they are intended to be deprecated and removed after a feature becomes GA or is dropped.

Also, turning off the gate would make a cluster non-conformant and couldn't reasonably be done by a managed cluster provider without breaking existing users.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 17, 2021

@saad-ali: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 17, 2021

/lgtm

Question 1: In my impression, there are several subpath-related issues and I did a quick search. Do we have a plan to think about the solution together? I will go through them once I have some reproducing environments.

_Question 2:
“VolumeSubpath was GAed since 1.10. Besides, VolumeSubpathEnvExpansion was also GAed since 1.17 (6 releases after that).”
Is there a plan to remove it? (EDITED: sorry, I find the website is not synced with the code. This feature gate is already removed in #89584)_

Loading

@saad-ali
Copy link
Member Author

@saad-ali saad-ali commented Sep 17, 2021

/sig storage

Loading

@saad-ali
Copy link
Member Author

@saad-ali saad-ali commented Sep 17, 2021

Question 1: In my impression, there are several subpath-related issues and I did a quick search. Do we have a plan to think about the solution together? I will go through them once I have some reproducing environments.

Good topic for discussion with SIG Storage. Want to add it to the agenda for the next meeting?

Loading

Remove the VolumeSubpath feature gate.

Feature gate convention has been updated since this was introduced to
indicate that they "are intended to be deprecated and removed after a
feature becomes GA or is dropped.".
@saad-ali saad-ali force-pushed the removeSubpathFeaturegate branch from 773736e to beb17fe Sep 17, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 17, 2021
@pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 17, 2021

Good topic for discussion with SIG Storage. Want to add it to the agenda for the next meeting?

I need to do some basic code reading and summary before raising it in the meeting. (If the meeting time is not convenient for me, I may raise the discussion in slack.) Thanks.

Loading

@saad-ali
Copy link
Member Author

@saad-ali saad-ali commented Sep 17, 2021

Good topic for discussion with SIG Storage. Want to add it to the agenda for the next meeting?

I need to do some basic code reading and summary before raising it in the meeting. (If the meeting time is not convenient for me, I may raise the discussion in slack.) Thanks.

Sounds good!

Loading

@thockin
Copy link
Member

@thockin thockin commented Sep 17, 2021

Thanks!

/lgtm
/approve

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@thockin
Copy link
Member

@thockin thockin commented Sep 17, 2021

There are issues with subpath, especially wrt projected volumes. I'd love to see us tackle that.

Loading

@k8s-ci-robot k8s-ci-robot merged commit 0d20f47 into kubernetes:master Sep 17, 2021
15 checks passed
Loading
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 17, 2021
@msau42
Copy link
Member

@msau42 msau42 commented Sep 30, 2021

I think we actually need to lock to default, and the deprecate for 2 releases before removing. Will send an update.

Loading

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Oct 4, 2021

@saad-ali: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@saad-ali
Copy link
Member Author

@saad-ali saad-ali commented Oct 4, 2021

#105474 is handling the release note for this PR.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment