-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove VolumeSubpath feature gate #105090
Remove VolumeSubpath feature gate #105090
Conversation
@saad-ali: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig storage |
Good topic for discussion with SIG Storage. Want to add it to the agenda for the next meeting? |
Remove the VolumeSubpath feature gate. Feature gate convention has been updated since this was introduced to indicate that they "are intended to be deprecated and removed after a feature becomes GA or is dropped.".
773736e
to
beb17fe
Compare
I need to do some basic code reading and summary before raising it in the meeting. (If the meeting time is not convenient for me, I may raise the discussion in slack.) Thanks. |
Sounds good! |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There are issues with subpath, especially wrt projected volumes. I'd love to see us tackle that. |
I think we actually need to lock to default, and the deprecate for 2 releases before removing. Will send an update. |
@saad-ali: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#105474 is handling the release note for this PR. |
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
Remove the VolumeSubpath feature gate.
Per @liggitt:
Feature gate convention has been updated since this feature gate was introduced to indicate that they
are intended to be deprecated and removed after a feature becomes GA or is dropped
.Also, turning off the gate would make a cluster non-conformant and couldn't reasonably be done by a managed cluster provider without breaking existing users.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: