-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock StorageObjectInUseProtection feature gate to default #105495
Lock StorageObjectInUseProtection feature gate to default #105495
Conversation
@ikeeip: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ikeeip. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a release note to indicate that the feature gate is deprecated?
ec7d48e
to
1349451
Compare
But isn't this enough?
|
I prefer that we explicitly state a feature gate is deprecated and shouldn't be used anymore, however I also took a look at a couple of other feature graduation PRs and don't see any mention of this. @deads2k do you think this is something we should be doing going forward? |
/ok-to-test |
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
As well as feature gate are locked, the tests when this feature is disabled will crash. So we should remove them together with locking the feature. Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
1349451
to
dbc9d7b
Compare
/retest |
I didn't get any response regarding the specific deprecation wording recommendation for the release note, and it doesn't look like we've been doing this for other features, so this looks ok. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ikeeip, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Would it be possible to mention the words “feature gate” in the release note here? |
See #105474 for an example of wording. |
Yes, fixed.
Thanks for the example. |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Lock
StorageObjectInUseProtection
feature gate to default.Which issue(s) this PR fixes:
Fixes N/A
Special notes for your reviewer:
Additional PR to make locking to default first before removing feature gates logic (#104903).
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: