Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Alternative services #106115

Closed
wants to merge 4 commits into from
Closed

[WIP] Alternative services #106115

wants to merge 4 commits into from

Conversation

aojea
Copy link
Member

@aojea aojea commented Nov 3, 2021

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Antonio Ojea added 2 commits November 3, 2021 12:58
clone url when cloning a request
8310824
add api server endpoints as alternative services headers
f77d793 
API servers publish the list of available API servers endpoints using
the Alt-Svc headers defined by RFC 7838 HTTP Alternative Services.

The list is obtained by the endpoints published for the
kubernetes.default service.
@k8s-ci-robot
Copy link
Contributor

@aojea: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 3, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 3, 2021
@aojea aojea mentioned this pull request Nov 3, 2021
Merged
new alternative service roundtripper
8d8ae06 
client-go custom round trippers that allows to use a list of alternative
apiservers to provide client side HA.

The list can be configured manually or automatically, parsing the
RFC7838 Alt-Svc headers.

The roundtripper, if there is an alternative service available, tries
to connect to it, falling back to the original Host.

Alternative Services present in the same host of the client are
preferred, if there are network errors connecting to the alternative
services the client retries aginst the rest of available services,
falling back to the original host.
@aojea aojea mentioned this pull request Nov 4, 2021
Closed
4 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
To complete the pull request process, please assign deads2k, sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @deads2k @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit 2885fac link true /test pull-kubernetes-unit
pull-kubernetes-integration 2885fac link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dcbw
dcbw reviewed Nov 8, 2021
View reviewed changes
staging/src/k8s.io/apiserver/pkg/server/filters/patch_alternative_services.go

// WithAternativeServices sets the Alt-Svc header based on the available api servers
// See RFC7838
func WithAternativeServices(handler http.Handler, a *AlternativeServicesInfo) http.Handler {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aojea WithAternativeServices -> WithAlternativeServices (missing 'l')

@k8s-ci-robot
Copy link
Contributor

@aojea: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2021
@fedebongio
Copy link
Contributor

/triage accepted
When it's ready for review/discussion please loop us in back
Thanks!

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 9, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 9, 2021
@aojea
Copy link
Member Author

aojea commented Nov 9, 2021

/triage accepted When it's ready for review/discussion please loop us in back Thanks!

The discussion has to happen first in the kep @fedebongio :)
kubernetes/enhancements#3037

@dims
Copy link
Member

dims commented Jan 14, 2022

/close

@dims
Copy link
Member

dims commented Jan 14, 2022

please reopen if you still need this WIP PR. Trying to declutter the open PR(s)

@k8s-ci-robot
Copy link
Contributor

@dims: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member Author

aojea commented Jan 15, 2022

sure, no prob 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw dcbw left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

Assignees
No one assigned
Labels
area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aojea @k8s-ci-robot @fedebongio @dims @dcbw