-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factored TimedObserver into less surprising pieces #106432
Factored TimedObserver into less surprising pieces #106432
Conversation
0bb6eb8
to
ab64e85
Compare
/cc @tkashem |
/lgtm @MikeSpreitzer - thanks for this PR - it doesn't address all my concerns, but it certainly helps a lot! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR factors the TimedObserver interface into a progression of three, starting with plain Observer, and renaming and explaining the methods so that hopefully the interfaces and implementations are easier to understand. The Observer interface has just one method, Observe, and is implemented by Prometheus Histograms, so should be very familiar. The "Timed" was taken out of the names because it had no real presence in the API.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: