Updating kubectl to use POST instead of GET for port-forward and exec

[nikhiljindal]

Fixes #10366

[k8s-bot]

GCE e2e build/test passed for commit f6bc8140857ee3caf7e183243d5f035653ccd5c7.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit b38d8b1.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[nikhiljindal]

cc @smarterclayton @bgrant0607 @lavalamp

@smarterclayton You said that we need to test this with HAProxy and an F5 proxy in front of our exec/portforward endpoints.
Can you please point me to how can I test it or can you test it?

Verified that e2e tests basic exec and port-forward: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/kubectl.go#L155

[smarterclayton]

I believe @ncdc did some quick testing.

On Jul 1, 2015, at 11:03 PM, Nikhil Jindal notifications@github.com wrote:

cc @smarterclayton https://github.com/smarterclayton @bgrant0607
https://github.com/bgrant0607 @lavalamp https://github.com/lavalamp

@smarterclayton https://github.com/smarterclayton You said that we need
to test this with HAProxy and an F5 proxy in front of our exec/portforward
endpoints.
Can you please point me to how can I test it or can you test it?

Verified that e2e tests basic exec and port-forward:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/kubectl.go#L155

—
Reply to this email directly or view it on GitHub
#10654 (comment)
.

[zmerlynn]

@jlowdermilk loves exec.

[ncdc]

I tested adding support for exec and port forwarding to use http_proxy/https_proxy env vars to be able to use a proxy to reach the master, as they currently don't. That worked against squid (I didn't test proxy auth though). I didn't test this with a reverse proxy in front of the master.

[j3ffml]

LGTM. Don't know about the ha/f5 proxy, but jenkins green is good enough for me.

[smarterclayton]

This is fine since we continue to support GET. LGTM

On Thu, Jul 2, 2015 at 12:53 PM, Jeff Lowdermilk notifications@github.com
wrote:

LGTM. Don't know about the ha/f5 proxy, but jenkins green is good enough
for me.

—
Reply to this email directly or view it on GitHub
#10654 (comment)
.

Clayton Coleman | Lead Engineer, OpenShift

[nikhiljindal]

@bgrant0607 for the final ok-to-merge

[nikhiljindal]

Maybe @zmerlynn or @thockin can give me a second LGTM?

[lavalamp]

Did you manually test? I didn't think there was an e2e test that covered this stuff. (If there is, then consider this an LGTM)

[nikhiljindal]

Yes there is an e2e test: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/kubectl.go#L155

I wasnt able to test it locally, since it required some additional softwares to be installed.

[bprashanth]

@lavalamp please apply ok-to-merge if you're fine with the test coverage

[thockin]

LGTM

Does the serve accept either POST or GET? Or is it currently broken?

[nikhiljindal]

Server accepts both POST and GET for now: #10509
Eventually, we will stop supporting GET: #10366

[bgrant0607]

LGTM
ok to merge