Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated released version tags for containerd and etcd #107206

Closed
wants to merge 1 commit into from

Conversation

NikhilSharmaWe
Copy link
Member

What type of PR is this?

Enhancement

What this PR does / why we need it:

We need to update versions of containerd and etcd first before we update outdated Opentelementary Go package.

Which issue(s) this PR fixes:

Fixes part of #106536

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 23, 2021
@k8s-ci-robot
Copy link
Contributor

@NikhilSharmaWe: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Dec 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NikhilSharmaWe
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NikhilSharmaWe
Copy link
Member Author

NikhilSharmaWe commented Dec 23, 2021

@dims

  • What steps I am missing in the process to update the version tags to the latest stable versions.
    if not then what is the cause for the error in this case.
  • Do I need to run command go mod vendor in the repo.

@k8s-ci-robot
Copy link
Contributor

@NikhilSharmaWe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd e7f3828 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-dependencies e7f3828 link true /test pull-kubernetes-dependencies
pull-kubernetes-verify e7f3828 link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member

pacoxu commented Dec 24, 2021

/sig architecture
/kind cleanup

To update a dependency,

  1. Use hack/pin-dependency.sh to switch to the preferred version for each module
  2. Run hack/update-vendor.sh to rebuild the vendor directory
  3. Run hack/lint-dependencies.sh to verify no additional changes are required

For instance:

hack/pin-dependency.sh github.com/Azure/go-autorest/autorest/adal v0.9.15
hack/update-vendor.sh
hack/lint-dependencies.sh

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 24, 2021
@NikhilSharmaWe
Copy link
Member Author

@pacoxu

user@DESKTOP-ISNGT7P MINGW64 /e/githubRepos/kubernetes (latver2)
$ hack/pin-dependency.sh github.com/containerd/cgroups v1.0.2
!!! [1224 18:31:59] Unsupported host OS.  Must be Linux or Mac OS X.
Running: go mod download github.com/containerd/cgroups@v1.0.2
Resolved to github.com/containerd/cgroups@v1.0.2
Running: go mod edit -require github.com/containerd/cgroups@v1.0.2
Running: go mod edit -replace github.com/containerd/cgroups=github.com/containerd/cgroups@v1.0.2

Run hack/update-vendor.sh to rebuild the vendor directory

user@DESKTOP-ISNGT7P MINGW64 /e/githubRepos/kubernetes (latver2)
$ hack/update-vendor.sh
!!! [1224 18:32:16] Unsupported host OS.  Must be Linux or Mac OS X.
+++ [1224 18:32:17] logfile at /tmp/update-vendor.vyU4/update-vendor.log
+++ [1224 18:32:17] go.mod: update staging references
: invalid path: malformed import path "k8s.io/api\r": invalid char '\r'
An error has occurred. Please see more details in /tmp/update-vendor.vyU4/update-vendor.log
  • When I run command hack/pin-dependency.sh github.com/containerd/cgroups v1.0.2 in Git Bash, it runs but also gives warning to run command in LinuxOS or MacOS. But after it when I run hack/update-vendor.sh it gives an error which can be seen above.

nikhil@DESKTOP-ISNGT7P:/mnt/e/githubRepos/kubernetes$ hack/pin-dependency.sh github.com/containerd/cgroups v1.0.2
/usr/bin/env: ‘bash\r’: No such file or directory
nikhil@DESKTOP-ISNGT7P:/mnt/e/githubRepos/kubernetes$
  • When I run command hack/pin-dependency.sh github.com/containerd/cgroups v1.0.2 in Ubuntu 20.04 LTS through wsl it gives this error. What should be done to run command successfully.

@NikhilSharmaWe
Copy link
Member Author

@pacoxu closed this PR by mistake, opened this one #107224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants