Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #107695: kubelet: fix podstatus not containing pod full name #108050

Closed
wants to merge 3 commits into from
Closed

Automated cherry pick of #107695: kubelet: fix podstatus not containing pod full name #108050

wants to merge 3 commits into from

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Feb 10, 2022 •
edited

Cherry pick of #107695 on release-1.22.

#107695: kubelet: fix podstatus not containing pod full name

Cherry pick of #107900 on release-1.22.

#107900: Pods that have terminated before starting should not block startup

For details on the cherry pick process, see the cherry pick requests page.

/kind bug regression
/priority critical-urgent
/triage accepted

Merged #107933 and #107932 into a single PR for backport to 1.22.

#107933 hasn't merged to 1.22 while it has already landed on 1.23: #107761

Both branches need #107900

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Feb 10, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

@ehashman: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 10, 2022
@gjkim42 @ehashman
Add an e2e test for updating a static pod while it restarts
6f11dc0
@gjkim42 @ehashman
kubelet: Clean up a static pod that has been terminated before starting
9f347da 
- Allow a podWorker to start if it is blocked by a pod that has been
  terminated before starting
- When a pod can't start AND has already been terminated, exit cleanly
- Add a unit test that exercises race conditions in pod workers
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehashman
To complete the pull request process, please assign sjenning after the PR has been reviewed.
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 10, 2022
@ehashman
Copy link
Member Author

/kind bug regression
/priority critical-urgent
/triage accepted

merged #107933 and #107932 into a single PR for backport to 1.22 since the first one didn't merge on 1.22 while it has already landed on 1.23: #107761

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 10, 2022
This was referenced Feb 10, 2022
Closed
Closed
@ehashman ehashman added this to Triage in SIG Node PR Triage Feb 11, 2022
@josefkarasek josefkarasek mentioned this pull request Feb 15, 2022
Merged
@gjkim42
Copy link
Member

gjkim42 commented Feb 15, 2022

/retest

@gjkim42
Copy link
Member

gjkim42 commented Feb 15, 2022

/retest

Maybe need rebase.

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Feb 16, 2022
@gjkim42
Copy link
Member

gjkim42 commented Feb 17, 2022 •
edited

@ehashman
Could you rebase this?

I think this should be cherry-picked before the next release with #107931

@rphillips
Copy link
Member

Elana is out... Recreating this PR with a rebase #108303

@rphillips
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@ehashman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit 9f347da link true /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link
Member

Is 1.22 missing a patch?

/tmp/go-build999606213/b3336/kubelet.test flag redefined: log_dir

@rphillips
Copy link
Member

rphillips commented Feb 23, 2022 •
edited

The error is from the klog.InitFlags() call... I updated the test in #108303

@rphillips
Copy link
Member

/close

in favor of #108303

SIG Node CI/Test Board automation moved this from Archive-it to Done Feb 23, 2022
@k8s-ci-robot
Copy link
Contributor

@rphillips: Closed this PR.

In response to this:

/close

in favor of #108303

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Triage to Done Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@vishh vishh Awaiting requested review from vishh

Assignees
No one assigned
Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehashman @k8s-ci-robot @gjkim42 @rphillips