Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2024643: Rebase v1.22.5 #1103

Merged

Conversation

josefkarasek
Copy link

Linus Arver and others added 30 commits August 9, 2021 22:15
Removing myself for now as I navigate the transition to the Prow team.
hostPath volume plugin creates a directory within /tmp on host machine, to be mounted as volume.
inject-pod writes content to the volume, and a client-pod tried the read the contents and verify.
when SELinux is enabled on the host, client-pod can not read the content, with permission denied.
running the client-pod as privileged, so that it can access the volume content, even when SEinux is enabled on the host.
During volume detach, the following might happen in reconciler

1. Pod is deleting
2. remove volume from reportedAsAttached, so node status updater will
update volumeAttached list
3. detach failed due to some issue
4. volume is added back in reportedAsAttached
5. reconciler loops again the volume, remove volume from
reportedAsAttached
6. detach will not be trigged because exponential back off, detach call
will fail with exponential backoff error
7. another pod is added which using the same volume on the same node
8. reconciler loops and it will NOT try to tigger detach anymore

At this point, volume is still attached and in actual state, but
volumeAttached list in node status does not has this volume anymore, and
will block volume mount from kubelet.

The fix in first round is to add volume back into the volume list that
need to reported as attached at step 6 when detach call failed with
error (exponentical backoff). However this might has some performance
issue if detach fail for a while. During this time, volume will be keep
removing/adding back to node status which will cause a surge of API
calls.

So we changed to logic to check first whether operation is safe to retry which
means no pending operation or it is not in exponentical backoff time
period before calling detach. This way we can avoid keep removing/adding
volume from node status.

Change-Id: I5d4e760c880d72937d34b9d3e904ecad125f802e
… fixes

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
…ck-of-#105734-upstream-release-1.22

Automated cherry pick of kubernetes#105734: Fix race condition in logging when request times out
…ick-of-#105511-upstream-release-1.22

Automated cherry pick of kubernetes#105511: Free APF seats for watches handled by an aggregated
…leged-storage-client

Cherry pick of kubernetes#104551: Run storage hostpath e2e test client pod as privileged
…pick-of-#105755-upstream-release-1.22

Automated cherry pick of kubernetes#105755: Support cgroupv2 in node problem detector test
…ick-of-#105997-release-1.22

Automated cherry pick of kubernetes#105997: Fixing how EndpointSlice Mirroring handles Service selector
…-pick-of-#105673-upstream-release-1.22

Automated cherry pick of kubernetes#105673: support more than 100 disk mounts on Windows
…ick-of-#105946-upstream-release-1.22

Automated cherry pick of kubernetes#105946: Remove nodes with Cluster Autoscaler taint from LB backends.
Update debian, debian-iptables, setcap images to pick up CVEs fixes
… logging (kubernetes#105137)

* added keys for structured logging

* used KObj

Co-authored-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
The logic to detect stale endpoints was not assuming the endpoint
readiness.

We can have stale entries on UDP services for 2 reasons:
- an endpoint was receiving traffic and is removed or replaced
- a service was receiving traffic but not forwarding it, and starts
to forward it.

Add an e2e test to cover the regression
Bump kube-openapi against kube-openapi/release-1.22 branch

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@vrutkovs
Copy link
Member

[Fail] [sig-network] Conntrack [It] should be able to preserve UDP traffic when initial unready endpoints get ready [Suite:openshift/conformance/parallel] [Suite:k8s] 
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes/runner.go:113

[Fail] [sig-network] Conntrack [It] should be able to preserve UDP traffic when initial unready endpoints get ready [Suite:openshift/conformance/parallel] [Suite:k8s] 
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes/runner.go:113

[Fail] [sig-network] Conntrack [It] should be able to preserve UDP traffic when initial unready endpoints get ready [Suite:openshift/conformance/parallel] [Suite:k8s] 
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes/runner.go:113

tests are permafailing

@danwinship
Copy link

The kube-proxy code in this PR doesn't get built in OCP; so you're running new e2e tests that depend on a kube-proxy bugfix in 1.22.5 against openshift-sdn's kube-proxy code which is based on https://github.com/openshift/kubernetes/tree/sdn-4.9-kubernetes-1.22.0-rc.0 and doesn't have that bugfix.

@openshift-ci-robot
Copy link

@josefkarasek: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@josefkarasek: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@soltysh
Copy link
Member

soltysh commented Mar 1, 2022

/override ci/prow/verify-commits
this one is expected to fail on k8s bumps

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits
this one is expected to fail on k8s bumps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Mar 1, 2022

/test k8s-e2e-aws-serial

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all the contents of this PR
/lgtm
/remove-label backports/unvalidated-commits
/label backport/validated-commits

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

@soltysh: The label(s) /label backport/validated-commits cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, backports/unvalidated-commits, backports/validated-commits, bugzilla/invalid-bug, bugzilla/valid-bug, cherry-pick-approved

In response to this:

Confirmed all the contents of this PR
/lgtm
/remove-label backports/unvalidated-commits
/label backport/validated-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Mar 1, 2022
@soltysh
Copy link
Member

soltysh commented Mar 1, 2022

/label backports/validated-commits

@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Mar 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josefkarasek, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented Mar 1, 2022

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@josefkarasek
Copy link
Author

/retest e2e-aws-csi

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

@josefkarasek: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test artifacts
  • /test configmap-scale
  • /test e2e-aws-downgrade
  • /test e2e-aws-fips
  • /test e2e-aws-jenkins
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-upgrade
  • /test images
  • /test integration
  • /test k8s-e2e-aws
  • /test k8s-e2e-aws-serial
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-five-control-plane-replicas
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-single-node
  • /test e2e-azure
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-csi-cinder
  • /test e2e-openstack-csi-manila
  • /test e2e-vsphere

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kubernetes-release-4.9-artifacts
  • pull-ci-openshift-kubernetes-release-4.9-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-release-4.9-e2e-aws-csi
  • pull-ci-openshift-kubernetes-release-4.9-e2e-aws-downgrade
  • pull-ci-openshift-kubernetes-release-4.9-e2e-aws-fips
  • pull-ci-openshift-kubernetes-release-4.9-e2e-aws-serial
  • pull-ci-openshift-kubernetes-release-4.9-e2e-aws-upgrade
  • pull-ci-openshift-kubernetes-release-4.9-e2e-azure-upgrade
  • pull-ci-openshift-kubernetes-release-4.9-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.9-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-release-4.9-images
  • pull-ci-openshift-kubernetes-release-4.9-integration
  • pull-ci-openshift-kubernetes-release-4.9-k8s-e2e-aws
  • pull-ci-openshift-kubernetes-release-4.9-k8s-e2e-aws-serial
  • pull-ci-openshift-kubernetes-release-4.9-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-release-4.9-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.9-k8s-e2e-gcp-five-control-plane-replicas
  • pull-ci-openshift-kubernetes-release-4.9-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-release-4.9-unit
  • pull-ci-openshift-kubernetes-release-4.9-verify
  • pull-ci-openshift-kubernetes-release-4.9-verify-commits

In response to this:

/retest e2e-aws-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Mar 1, 2022

/test e2e-agnostic-cmd

@josefkarasek
Copy link
Author

/test e2e-aws-csi

@josefkarasek
Copy link
Author

/test e2e-aws-downgrade

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

@josefkarasek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits 91ce514 link true /test verify-commits

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5c84e52 into openshift:release-4.9 Mar 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

@josefkarasek: All pull requests linked via external trackers have merged:

Bugzilla bug 2024643 has been moved to the MODIFIED state.

In response to this:

Bug 2024643: Rebase v1.22.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet