Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update publishing-bot rules for Go 1.17.7 / 1.16.14 #108103

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Update publishing-bot rules for Go 1.17.7 / 1.16.14 #108103

merged 1 commit into from
Feb 14, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 14, 2022

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update publishing-bot rules for Go 1.17.7 / 1.16.14.

Which issue(s) this PR fixes:

xref kubernetes/release#2425

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @cpanato @saschagrunert @palnabarun @puerco @justaugustus
cc @kubernetes/release-engineering

@xmudrii
Update publishing-bot rules for Go 1.17.7 / 1.16.14
b9abd5a 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes labels Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Feb 14, 2022

/hold
until #108102, #108101, and #108100 are not merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Feb 14, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 14, 2022
@xmudrii xmudrii mentioned this pull request Feb 14, 2022
Closed
23 tasks
@dims
Copy link
Member

dims commented Feb 14, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Feb 14, 2022

/hold cancel
All branches are now updated

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 67b2b34 into kubernetes:master Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 14, 2022
@xmudrii xmudrii deleted the go-update-publishing-rules branch February 14, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@dims dims

@justaugustus justaugustus

@saschagrunert saschagrunert

@puerco puerco

@cpanato cpanato

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
8 participants
@xmudrii @dims @k8s-ci-robot @saschagrunert @justaugustus @puerco @cpanato @palnabarun