Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly attribute some data structures from gotestsum repository #109170

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Correctly attribute some data structures from gotestsum repository #109170

merged 1 commit into from
Apr 2, 2022

Conversation

dims
Copy link
Member

@dims dims commented Mar 31, 2022

These data structures represent the xml in the junit format. These would be EXACTLY the same even if i had typed it by hand. In this case i picked up these from the gotestsum repo. We can't vendor these as these are marked "internal" as well. Here's the original:
https://github.com/gotestyourself/gotestsum/blob/main/internal/junitxml/report.go#L18-L63

In this PR we are trying to do the right thing by adding the NOTICE/LICENSE under the third_party directory as we do usually for such code.

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 31, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 31, 2022
@dims
Copy link
Member Author

dims commented Mar 31, 2022

/assign @liggitt @BenTheElder

@dims
Copy link
Member Author

dims commented Mar 31, 2022

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 31, 2022
@dims
Copy link
Member Author

dims commented Mar 31, 2022

/milestone v1.24

@JamesLaverack would you like me to file an exception for this? it's not code that ends up in a kubernetes cluster, it is used in the CI / test harness to cleanup junit xml that is too large. So we should be treating this as a test exception. Happy to do either, just let me know.

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 31, 2022
@dims dims mentioned this pull request Mar 31, 2022
Merged
@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

CI failure looks legitimate

thanks for the relocate and explicit license addition

@dims dims force-pushed the correctly-attribute-some-data-structures-from-gotestsum branch from aea030e to 96e3059 Compare March 31, 2022 02:13
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2022
@dims
Copy link
Member Author

dims commented Mar 31, 2022

fixed (ran hack/update-vendor.sh) thanks @liggitt

@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2022
@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

/hold

unit test failing:

=== FAIL: cmd/prune-junit-xml TestPruneXML (0.01s)
    prunexml_test.go:65: 
        	Error Trace:	prunexml_test.go:65
        	Error:      	Not equal: 
        	            	expected: "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<testsuites>\n\t<testsuite tests=\"3\" failures=\"1\" time=\"271.610000\" name=\"k8s.io/kubernetes/test/integration/apiserver\" timestamp=\"\">\n\t\t<properties>\n\t\t\t<property name=\"go.version\" value=\"go1.18 linux/amd64\"></property>\n\t\t</properties>\n\t\t<testcase classname=\"k8s.io/kubernetes/test/integration/apimachinery\" name=\"TestWatchRestartsIfTimeoutNotReached/group/InformerWatcher_survives_closed_watches\" time=\"30.050000\"></testcase>\n\t\t<testcase classname=\"k8s.io/kubernetes/test/integration/apiserver\" name=\"TestMaxResourceSize/JSONPatchType_should_handle_a_patch_just_under_the_max_limit\" time=\"0.000000\">\n\t\t\t<skipped message=\"[... clipped...]ust_under_the_max_limit (0.00s)&#xA;\"></skipped>\n\t\t</testcase>\n\t\t<testcase classname=\"k8s.io/kubernetes/test/integration/apimachinery\" name=\"TestSchedulerInformers\" time=\"-0.000000\">\n\t\t\t<failure message=\"Failed\" type=\"\">[... clipped...]prometheus/client_metrics.go:160</failure>\n\t\t</testcase>\n\t</testsuite>\n</testsuites>"
        	            	actual  : "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<testsuites></testsuites>"
        	            	
        	            	Diff:
        	            	--- Expected

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

verify failure is fixed in #109195

@dims dims force-pushed the correctly-attribute-some-data-structures-from-gotestsum branch from 4676316 to cadfcdc Compare March 31, 2022 13:17
@dims
Copy link
Member Author

dims commented Mar 31, 2022

verify failure is fixed in #109195

thanks @liggitt ! will wait for that to merge

@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

/retest

@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2022
@dims
Copy link
Member Author

dims commented Mar 31, 2022

/retest

2 similar comments
@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

/retest

@liggitt
Copy link
Member

liggitt commented Mar 31, 2022

/retest

BenTheElder
BenTheElder approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks!

the integration flakes seem really concerning. I know we're tracking this already.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@liggitt
Copy link
Member

liggitt commented Apr 1, 2022

/retest

1 similar comment
@pacoxu
Copy link
Member

pacoxu commented Apr 1, 2022

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@pacoxu
Copy link
Member

pacoxu commented Apr 1, 2022

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@dims
Copy link
Member Author

dims commented Apr 1, 2022

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@dims
Correctly attribute some datastructures from gotestsum repository
108e3e2 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the correctly-attribute-some-data-structures-from-gotestsum branch from cadfcdc to 108e3e2 Compare April 1, 2022 18:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
@dims
Copy link
Member Author

dims commented Apr 1, 2022

@liggitt rebased this again. hoping it will help with flakes (and lost the lgtm)

@liggitt
Copy link
Member

liggitt commented Apr 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot
Copy link
Contributor

@dims: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit 108e3e2 link unknown /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member

pacoxu commented Apr 2, 2022

Test_Run_OneVolumeDetachFailNodeWithReadWriteOnce flake #107414
/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot merged commit d6ad0ff into kubernetes:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@thockin thockin Awaiting requested review from thockin

Assignees

@BenTheElder BenTheElder

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-blocker release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dims @k8s-ci-robot @liggitt @k8s-triage-robot @pacoxu @BenTheElder