Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regenerate openapi with 1.24 removed alpha CSIStorageCapacity API #109195

Closed
wants to merge 1 commit into from
Closed

regenerate openapi with 1.24 removed alpha CSIStorageCapacity API #109195

wants to merge 1 commit into from

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 31, 2022

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

There is one alpha API targeting automatic removal in 1.24. When the beta.0 tag was created, that kicked in automatically and is failing master validation of the generated openapi spec.

NONE

/milestone v1.24
/priority critical-urgent
/cc @deads2k

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Mar 31, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 31, 2022
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 31, 2022
@liggitt liggitt changed the title regenerate openapi with 1.24 removed APIs regenerate openapi with 1.24 removed alpha CSIStorageCapacity API Mar 31, 2022
This was referenced Mar 31, 2022
Merged
Merged
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@liggitt liggitt mentioned this pull request Mar 31, 2022
Merged
@liggitt liggitt added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Mar 31, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 31, 2022
@liggitt liggitt added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 31, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 31, 2022
@liggitt
Copy link
Member Author

liggitt commented Mar 31, 2022

/retest

@dims
Copy link
Member

dims commented Mar 31, 2022

/assign @xing-yang

@liggitt liggitt mentioned this pull request Mar 31, 2022
Merged
@liggitt
Copy link
Member Author

liggitt commented Mar 31, 2022

/retest

pohly
pohly approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022
@k8s-ci-robot
Copy link
Contributor

@liggitt: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2022
@pohly
Copy link
Contributor

pohly commented Mar 31, 2022

When the beta.0 tag was created, that kicked in automatically and is failing master validation of the generated openapi spec.

Sounds like a chicken-and-egg problem with the automatism? Would it have been possible to avoid this by removing the alpha API manually beforehand?

@liggitt
Copy link
Member Author

liggitt commented Mar 31, 2022

Would it have been possible to avoid this by removing the alpha API manually beforehand?

yes

@liggitt
Copy link
Member Author

liggitt commented Mar 31, 2022

got picked up and merged in #109151

@liggitt liggitt closed this Mar 31, 2022
@liggitt liggitt deleted the openapi-1.24 branch May 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@pohly pohly

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
CI Signal (SIG Release / Release Team)
Status: RESOLVED
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @dims @k8s-ci-robot @pohly @xing-yang