Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REQUEST: nominate kerthcet as sig scheduling reviewer #110638

Merged
merged 1 commit into from
Jun 21, 2022
Merged

REQUEST: nominate kerthcet as sig scheduling reviewer #110638

merged 1 commit into from
Jun 21, 2022

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Jun 17, 2022 •
edited

Signed-off-by: kerthcet kerthcet@gmail.com

Hi sig scheduling team, I have been contributing to the Kubernetes community for quite a long time( no doubt will continue longer), and learned a lot from all of your guys, thanks so much.
I want to nominate myself as a member of the reviewer team, it's not only a honor but also a kind of responsibility to me.

Reviewer requirements:

  1. member for at least 3 months: REQUEST: New membership for kerthcet org#2877
  2. Primary reviewer for at least 5 PRs to the codebase: Reviewed 33 Merged PRs
  3. Reviewed or merged at least 20 substantial PRs to the codebase: Merged 28 PRs

Others:

  1. Author of KEP: take toleration/taints into considering when computing skew
  2. Actively contributing to kubernetes-sigs/kueue
  3. Actively contributing to other sigs also.

/sig scheduling
/kind document

@kerthcet
nominate kerthcet as sig scheduler reviewer
0f4b549 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 17, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: The label(s) kind/document cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: kerthcet kerthcet@gmail.com

Hi sig scheduling team, I have been contributing to the Kubernetes community for quite a long time( no doubt will continue longer), and learned a lot from all of your guys, thanks so much.
I want to nominate myself as a member of the reviewer team, it's not only a honor but also a kind of responsibility to me.

Reviewer requirements:

  1. member for at least 3 months: REQUEST: New membership for kerthcet org#2877
  2. Primary reviewer for at least 5 PRs to the codebase: Reviewed 33 Merged PRs
  3. Reviewed or merged at least 20 substantial PRs to the codebase: Merged 28 PRs

/sig scheduling
/kind document

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 17, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 17, 2022
@kerthcet
Copy link
Member Author

cc @ahg-g @alculquicondor @Huang-Wei

@kerthcet
Copy link
Member Author

/kind document

@k8s-ci-robot
Copy link
Contributor

@kerthcet: The label(s) kind/document cannot be applied, because the repository doesn't have them.

In response to this:

/kind document

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kerthcet
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 17, 2022
@kerthcet
Copy link
Member Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 17, 2022
@alculquicondor
Copy link
Member

+1

Thanks for your contributions so far @kerthcet. I support your nomination :)

@Huang-Wei
Copy link
Member

+1, looking forward to more contributions in the future!

@kerthcet
Copy link
Member Author

kerthcet commented Jun 20, 2022 •
edited

Thanks for all your helps!

@denkensk
Copy link
Member

+1 😄

@ahg-g
Copy link
Member

ahg-g commented Jun 21, 2022

+1, thanks!

@kerthcet
Copy link
Member Author

/assign @liggitt
for approval, thanks all.

@liggitt
Copy link
Member

liggitt commented Jun 21, 2022

/lgtm
/approve

per +1's from sig-scheduling leads

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerthcet, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit 0f4b549 link unknown /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alculquicondor
Copy link
Member

unit tests are flaky #110697

/retest

@k8s-ci-robot k8s-ci-robot merged commit e1f5282 into kubernetes:master Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 21, 2022
@kerthcet kerthcet deleted the feat/nominate-to-reviewer branch June 21, 2022 22:48
@kerthcet kerthcet changed the title REQUEST: nominate kerthcet as sig scheduler reviewer REQUEST: nominate kerthcet as sig scheduling reviewer Jun 22, 2022
@kerthcet kerthcet mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kerthcet @k8s-ci-robot @alculquicondor @Huang-Wei @denkensk @ahg-g @liggitt