New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ignore all event resource for gc #110888
feat: ignore all event resource for gc #110888
Conversation
Hi @likakuli. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @Jefftree |
@lavalamp could you please review it, thanks. |
/ok-to-test |
{Group: "", Resource: "events"}: {}, | ||
{Group: "", Resource: "events"}: {}, | ||
{Group: eventv1.GroupName, Resource: "events"}: {}, | ||
{Group: eventv1beta1.GroupName, Resource: "events"}: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the statement here eventv1beta1 is deprecated in 1.22.So I guess v1 is enough.
// +k8s:prerelease-lifecycle-gen:deprecated=1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i have removed the v1beta1 version, thx
I think it's more of a bug, not a feature. |
af2b96a
to
621691b
Compare
Signed-off-by: likakuli <1154584512@qq.com>
621691b
to
74a3b8f
Compare
/assign @deads2k |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, likakuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
ignore events in all groups for gc
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: